Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] settings dialogs from develop branch #2039

Closed
wants to merge 52 commits into from
Closed

[WIP] settings dialogs from develop branch #2039

wants to merge 52 commits into from

Conversation

panaC
Copy link
Member

@panaC panaC commented Nov 23, 2023

No description provided.

panaC and others added 11 commits November 23, 2023 09:18
@panaC
squash merge from arthur/ui/settings-dialog
bb0f9d2
@panaC
up package-lock
bba8a52
@panaC
type DialogWIthRadix children
080c63f
@panaC
lint
4583c1e
@panaC
Squashed commit of the following:
2ee6dc0 
commit 2e3be34
Author: Arthur Le Meur <[email protected]>
Date:   Wed Nov 22 16:22:19 2023 +0100

    refactor settings components + lint

commit c313717
Author: Arthur Le Meur <[email protected]>
Date:   Wed Nov 22 10:11:40 2023 +0100

    WIP settings reading options

commit 5214932
Author: Arthur Le Meur <[email protected]>
Date:   Wed Nov 22 10:11:35 2023 +0100

    WIP settings reading options

commit d98334f
Author: Arthur Le Meur <[email protected]>
Date:   Tue Nov 21 13:46:11 2023 +0100

    WIP settings display options + lint

commit 2dd2204
Merge: f47364c 39f0bea
Author: Arthur Le Meur <[email protected]>
Date:   Mon Nov 20 14:41:43 2023 +0100

    Merge branch 'develop' into arthur/ui/settings-dialog

commit f47364c
Author: Arthur Le Meur <[email protected]>
Date:   Mon Nov 20 14:40:54 2023 +0100

    WIP font settings dispatch

commit d25168d
Merge: bc1f8b1 ec61bea
Author: Arthur Le Meur <[email protected]>
Date:   Mon Nov 20 10:06:33 2023 +0100

    Merge branch 'develop' into arthur/ui/settings-dialog

commit bc1f8b1
Author: Arthur Le Meur <[email protected]>
Date:   Mon Nov 20 09:44:05 2023 +0100

    WIP settings modal

commit 2fc4fca
Merge: 67f18bd 824e7a4
Author: Arthur Le Meur <[email protected]>
Date:   Thu Nov 16 14:27:45 2023 +0100

    Merge branch 'arthur/ui/settings-dialog' of https://github.com/edrlab/thorium-reader into arthur/ui/settings-dialog

commit 67f18bd
Merge: d4e638a 7606f91
Author: Arthur Le Meur <[email protected]>
Date:   Thu Nov 16 12:04:45 2023 +0100

    Merge branch 'develop' into arthur/ui/dialog

commit 824e7a4
Author: Arthur Le Meur <[email protected]>
Date:   Wed Nov 15 15:48:40 2023 +0100

    WIP create componants for Reader Options

commit 3356581
Author: Arthur Le Meur <[email protected]>
Date:   Wed Nov 15 10:47:13 2023 +0100

    WIP update Settings dialog

commit 587deba
Merge: 08aeca7 88754b0
Author: Arthur Le Meur <[email protected]>
Date:   Tue Nov 14 09:33:10 2023 +0100

    Merge branch 'arthur/ui/sass1' into arthur/ui/settings-dialog

commit 88754b0
Author: Arthur Le Meur <[email protected]>
Date:   Mon Nov 13 17:44:50 2023 +0100

    add typed-scss-modules

commit b4ad98a
Author: Pierre Leroux <[email protected]>
Date:   Mon Nov 13 17:23:17 2023 +0100

    Revert "add scss typed cli in style-typed cmd"

    This reverts commit afa269f.

commit 08aeca7
Merge: fc19312 df2872c
Author: Arthur Le Meur <[email protected]>
Date:   Mon Nov 13 17:09:58 2023 +0100

    Merge branch 'develop' of https://github.com/edrlab/thorium-reader into arthur/ui/settings-dialog

commit afa269f
Author: Arthur Le Meur <[email protected]>
Date:   Mon Nov 13 17:02:29 2023 +0100

    add scss typed cli in style-typed cmd

commit 235a5a7
Merge: 6995ed1 df2872c
Author: Pierre Leroux <[email protected]>
Date:   Mon Nov 13 16:48:44 2023 +0100

    Merge branch 'develop' of https://github.com/edrlab/thorium-reader into arthur/ui/sass1

commit fc19312
Merge: 228a84a 6995ed1
Author: Arthur Le Meur <[email protected]>
Date:   Mon Nov 13 16:04:33 2023 +0100

    Merge branch 'arthur/ui/sass1' into arthur/ui/settings-dialog

commit 6995ed1
Author: Pierre Leroux <[email protected]>
Date:   Mon Nov 13 15:57:55 2023 +0100

    fix: sass-loader with webpack import module, add style-typed for scss file

commit 228a84a
Author: Arthur Le Meur <[email protected]>
Date:   Mon Nov 13 14:25:31 2023 +0100

    lint

commit e678a42
Author: Arthur Le Meur <[email protected]>
Date:   Mon Nov 13 14:24:50 2023 +0100

    package-lock

commit e77cd35
Merge: 085927e 44508ec
Author: Arthur Le Meur <[email protected]>
Date:   Mon Nov 13 14:23:41 2023 +0100

    Merge branch 'arthur/ui/sass1' into arthur/ui/settings-dialog

commit d4e638a
Author: Arthur Le Meur <[email protected]>
Date:   Mon Nov 13 12:39:38 2023 +0100

    fix lint

commit 8913c15
Author: Arthur Le Meur <[email protected]>
Date:   Mon Nov 13 11:54:47 2023 +0100

    update buttons disable style

commit e028961
Author: Arthur Le Meur <[email protected]>
Date:   Mon Nov 13 11:31:53 2023 +0100

    WIP update all dialogs design

commit a517b0e
Author: Arthur Le Meur <[email protected]>
Date:   Wed Nov 8 13:57:38 2023 +0100

    update UI catalog dialogs

commit 416f2e0
Author: Arthur Le Meur <[email protected]>
Date:   Tue Nov 7 16:51:05 2023 +0100

    update UI publicationInfo dialog

commit 8aa3cb0
Author: Arthur Le Meur <[email protected]>
Date:   Tue Nov 7 09:35:05 2023 +0100

    up CSS pubInfo dialog

commit 44508ec
Author: Pierre Leroux <[email protected]>
Date:   Tue Nov 7 09:03:07 2023 +0100

    Revert "Fix(reader): enable reader keyboard shortcut on publication info close"

    This reverts commit b2b41b6.

commit bddc4b2
Author: Pierre Leroux <[email protected]>
Date:   Tue Nov 7 08:09:13 2023 +0100

    install node-sass in dev-deps

commit 610499e
Author: Pierre Leroux <[email protected]>
Date:   Tue Nov 7 08:03:50 2023 +0100

    remove sass package and npm i -D sass-loader

commit 0b5186c
Author: Pierre Leroux <[email protected]>
Date:   Tue Nov 7 07:59:48 2023 +0100

    lint and remove node-sass from dep

commit 6cdd4b2
Merge: b2b41b6 f281659
Author: Pierre Leroux <[email protected]>
Date:   Tue Nov 7 07:53:13 2023 +0100

    Merge branch 'arthur/ui/sass1' of https://github.com/edrlab/thorium-reader into arthur/ui/sass1

commit 9881fc8
Merge: 5278936 f281659
Author: Arthur Le Meur <[email protected]>
Date:   Mon Nov 6 17:26:27 2023 +0100

    Merge branch 'arthur/ui/sass1' into arthur/ui/dialog

commit f281659
Author: Arthur Le Meur <[email protected]>
Date:   Mon Nov 6 17:23:43 2023 +0100

    package-lock update

commit 7d67fb5
Merge: 0cdf88d 0318e81
Author: Arthur Le Meur <[email protected]>
Date:   Mon Nov 6 17:21:36 2023 +0100

    Merge branch 'develop' into arthur/ui/sass1

commit 5278936
Author: Arthur Le Meur <[email protected]>
Date:   Mon Nov 6 17:19:19 2023 +0100

    up

commit 2c6a08f
Merge: ce731fa 0cdf88d
Author: Arthur Le Meur <[email protected]>
Date:   Mon Nov 6 17:17:17 2023 +0100

    Merge branch 'arthur/ui/sass1' into arthur/ui/dialog

commit 0cdf88d
Author: Arthur Le Meur <[email protected]>
Date:   Mon Nov 6 17:06:30 2023 +0100

    update sass variables

commit a60ed6d
Author: Arthur Le Meur <[email protected]>
Date:   Mon Nov 6 16:51:58 2023 +0100

    add color buttons variable

commit 085927e
Author: Pierre Leroux <[email protected]>
Date:   Mon Nov 6 16:12:47 2023 +0100

    add radix-select

commit f8c1bd3
Author: Arthur Le Meur <[email protected]>
Date:   Mon Nov 6 10:25:16 2023 +0100

    update style in settings modal

commit 9ac73b2
Merge: b903cd2 f8da522
Author: Pierre Leroux <[email protected]>
Date:   Mon Oct 30 11:38:02 2023 +0100

    Merge branch 'develop' into arthur/ui/settings-dialog

commit ce731fa
Merge: 82bbacc f8da522
Author: Pierre Leroux <[email protected]>
Date:   Mon Oct 30 11:35:28 2023 +0100

    Merge branch 'develop' into arthur/ui/dialog

commit b903cd2
Author: Arthur Le Meur <[email protected]>
Date:   Sat Oct 28 12:42:49 2023 +0200

    add css + themes + settings as icon

commit c766618
Author: Arthur Le Meur <[email protected]>
Date:   Thu Oct 26 16:59:49 2023 +0200

    implemented Radix-Select for language + lint fixes

commit 82bbacc
Author: Pierre Leroux <[email protected]>
Date:   Thu Oct 26 10:05:50 2023 +0200

    fix: form end tag in opdsAddFeed

    css footer broken

commit ae359be
Author: Pierre Leroux <[email protected]>
Date:   Thu Oct 26 09:31:12 2023 +0200

    fix: DialogWithRadix common import

commit 2fbdb7e
Author: Arthur Le Meur <[email protected]>
Date:   Wed Oct 25 15:05:28 2023 +0200

    fix css for adding opds modal

commit 15a1b26
Merge: c49946b 178fb92
Author: Arthur Le Meur <[email protected]>
Date:   Wed Oct 25 14:23:40 2023 +0200

    Merge remote-tracking branch 'refs/remotes/origin/arthur/ui/dialog' into arthur/ui/dialog

commit c49946b
Author: Arthur Le Meur <[email protected]>
Date:   Wed Oct 25 14:18:12 2023 +0200

    edit dialogwithradix css

commit e0969ab
Author: Arthur Le Meur <[email protected]>
Date:   Wed Oct 25 14:13:14 2023 +0200

    WIP implementing settings in dialog

commit 178fb92
Author: Pierre Leroux <[email protected]>
Date:   Wed Oct 25 13:47:52 2023 +0200

    fix: DialogWithRadix typing and context

commit fdd6b1c
Author: Arthur Le Meur <[email protected]>
Date:   Mon Oct 23 16:52:32 2023 +0200

    update color variables for themes

commit 0ac91d7
Author: Pierre Leroux <[email protected]>
Date:   Mon Oct 23 16:13:27 2023 +0200

    up opds feed add form

commit 720d6a9
Author: Pierre Leroux <[email protected]>
Date:   Mon Oct 23 14:43:49 2023 +0200

    apiApp okay

commit 1b4b213
Author: Arthur Le Meur <[email protected]>
Date:   Mon Oct 23 12:53:06 2023 +0200

    WIP dialog template

commit 7ed6c2b
Author: Arthur Le Meur <[email protected]>
Date:   Wed Oct 18 15:43:07 2023 +0200

    WIP refactor apiApp modal

commit afb163a
Author: Arthur Le Meur <[email protected]>
Date:   Wed Oct 11 15:31:52 2023 +0200

    fix CI lint

commit f9b1574
Author: Arthur Le Meur <[email protected]>
Date:   Wed Oct 11 15:07:16 2023 +0200

    test theme-mode from user system

commit c5d0d2a
Author: Arthur Le Meur <[email protected]>
Date:   Mon Sep 25 13:27:34 2023 +0200

    test implementation Sass sur Settings.tsx
@panaC
up package-lock
9b504b2
@panaC
up style-typed
c1dcb86
@panaC
checkout readerOption
4b36b03
@panaC
clean
b02e398
@panaC
delete some files
1ffcb83
@arthur-lemeur
fix night mode
6ecef6a
@panaC panaC mentioned this pull request Nov 23, 2023
Closed
@socket-security Socket Security
Copy link

socket-security bot commented Nov 27, 2023 •
edited
Loading

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@radix-ui/react-tabs 1.0.4 None +3 191 kB benoitgrelard
@radix-ui/react-radio-group 1.1.3 None +5 237 kB benoitgrelard
react-select 5.8.0 environment +20 2.71 MB
@radix-ui/react-popover 1.0.7 None +9 692 kB benoitgrelard
@radix-ui/react-select 2.0.0 None +14 1.06 MB benoitgrelard

@panaC
Copy link
Member Author

panaC commented Dec 4, 2023

image
image

need to fix modal width

@panaC
Copy link
Member Author

panaC commented Dec 4, 2023 •
edited
Loading

image

save session and wipe button not connected

fixed with 78dbcfd

@panaC
Copy link
Member Author

panaC commented Dec 4, 2023 •
edited
Loading

focus order : tab reading -> close cross -> content and not tab to content focus

image

@panaC
Copy link
Member Author

panaC commented Dec 4, 2023

input font outline not centered
image

@panaC
Copy link
Member Author

panaC commented Jan 10, 2024

i'm closing it, I've merged both settings-reader-2024 and settings-library-2024 in ui UI/UX master branch.

@panaC panaC closed this Jan 10, 2024
@danielweck danielweck deleted the arthur/ui/settings branch April 25, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@panaC @arthur-lemeur