Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEV] REACT18 #1999

Closed
wants to merge 3 commits into from
Closed

[DEV] REACT18 #1999

wants to merge 3 commits into from

Conversation

panaC
Copy link
Member

@panaC panaC commented Sep 18, 2023

remove 'react-beautiful-dnd' seems not used at all

update react et react-dom to latest version 18.2.0

update react-axe to new version

fixed typing error in react18 due to lack of children type in props by default

@panaC panaC requested a review from danielweck September 18, 2023 11:30
@panaC panaC self-assigned this Sep 18, 2023
@socket-security
Copy link

socket-security bot commented Sep 18, 2023

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
r2-opds-js 1.0.42 network, environment +0 1.73 MB danielweck
@axe-core/react 4.7.3 None +0 26.6 kB npmdeque
@types/react-dom 17.0.20...18.2.7 None +0/-1 30.2 kB types
react 17.0.2...18.2.0 None +0/-0 316 kB gnoff
react-dom 17.0.2...18.2.0 None +2/-2 4.91 MB gnoff

🚮 Removed packages: @types/[email protected], @types/[email protected], [email protected], [email protected]

@panaC panaC mentioned this pull request Sep 19, 2023
@panaC panaC changed the title [dev] REACT18 [DEV] REACT18 Sep 19, 2023
Copy link
Member

@danielweck danielweck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that the scope of the "React18" PR (see original #1693 ) should strictly be constrained to the changes necessary for React upgrade. I see that "react-redux" is missing here (updated in the original PR). I also see that Deque Axe is changed unnecessarily, and the DND package removed too. These changes are unrelated to React18.
Rationale: the Thorium forks might not be ready for React18 upgrade, which is why the small original PR was laser-focussed on identifying the code gaps, and potential pitfalls for Thorium forks. Maybe now is the right time to force an upgrade, let's discuss.
But I would like to understand the motivation for a separate React18 PR (additional code changes since commits to the develop branch? ... if so, let's align the original PR with develop)

@panaC
Copy link
Member Author

panaC commented Sep 26, 2023

I'm removing this branch, Daniel original branch merged.

@panaC panaC closed this Sep 26, 2023
@panaC panaC deleted the react18 branch September 26, 2023 08:37
@panaC panaC restored the react18 branch November 23, 2023 08:25
@panaC panaC deleted the react18 branch November 23, 2023 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants