Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate output from querying #41

Open
2 tasks
edeckers opened this issue Mar 9, 2022 · 0 comments · May be fixed by #55
Open
2 tasks

Separate output from querying #41

edeckers opened this issue Mar 9, 2022 · 0 comments · May be fixed by #55
Assignees
@edeckers
Labels
enhancement New feature or request

Comments

@edeckers
Copy link
Owner

edeckers commented Mar 9, 2022

Querying and output are very intertwined in the current setup, which makes the handling of queries to the agent API kind of awkward

huemon/src/huemon/api_server.py

Line 27 in 4a5ac7e

context_reader = io.StringIO()

  • Wrap method results in eithers and options instead of calling sys.exit and printing
  • Add processors that handle printing results
@edeckers edeckers added the enhancement New feature or request label Mar 9, 2022
@edeckers edeckers self-assigned this Mar 9, 2022
@edeckers edeckers mentioned this issue Mar 10, 2022
Merged
@edeckers edeckers linked a pull request Mar 12, 2022 that will close this issue
perf: separate queries from printing #55
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@edeckers edeckers

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

perf: separate queries from printing edeckers/huemon
1 participant
@edeckers