refactor 'cron' job scheduling

econya · Oct 12, 2020 · db1916b · db1916b
1 parent 3aeb043
commit db1916b
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/app/lib/scheduled_job_check.rb b/app/lib/scheduled_job_check.rb
@@ -3,7 +3,6 @@
 # SPDX-License-Identifier: AGPL-3.0-or-later
 
 class ScheduledJobCheck
-
   def self.all_cron_job_classes
     glob = Rails.root.join('app', 'jobs', '**', '*_job.rb')
     Dir.glob(glob).each {|f| require f}
@@ -14,7 +13,8 @@ def self.all_scheduled?
     all_cron_job_classes.all? { |job| job.scheduled? }
   end
 
-  def self.schedule_all
-    all_cron_job_classes.each { |job| job.scheduled }
+  def self.schedule_all!
+    Rails.logger.info 'Scheduling all cronish jobs'
+    all_cron_job_classes.each { |job| job.schedule }
   end
 end
diff --git a/lib/tasks/jobs.rake b/lib/tasks/jobs.rake
@@ -5,9 +5,7 @@
 namespace :db do
   desc 'Schedule all cron jobs'
   task schedule_jobs: :environment do
-    glob = Rails.root.join('app', 'jobs', '**', '*_job.rb')
-    Dir.glob(glob).each {|f| require f}
-    CronJob.subclasses.each { |job| job.schedule }
+    ScheduledJobCheck.schedule_all!
   end
 end