Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pyproject.toml and src rootdir #48

Merged
merged 4 commits into from
May 8, 2024
Merged

Conversation

sandorkertesz
Copy link
Collaborator

@sandorkertesz sandorkertesz commented May 8, 2024

This PR adds the following changes:

  • uses pyproject.toml instead of setup.py
  • uses the src/earthkit source structure

Please note that temporarily we have this option in pyproject.toml:

[tool.setuptools.packages.find]
include = ["earthkit", "earthkit.*"]
where = ["src/", "./"]

This is to make earthkit components not yet using the new src/earthkit/ source structure work. The downside of it is that we cannot query the version of earthkit itself when earthkit is installed from the local git repo as pip install -e .. However, this is only a concern for developments.

Once all the earthkit components are converted we should use:

[tool.setuptools.packages.find]
include = ["earthkit"]
where = ["src/"]

@sandorkertesz sandorkertesz changed the title Feature/pyroject toml Feature/pyproject toml May 8, 2024
@sandorkertesz sandorkertesz changed the title Feature/pyproject toml Use pyproject toml and src rootdir May 8, 2024
@sandorkertesz sandorkertesz changed the title Use pyproject toml and src rootdir Use pyproject.toml and src rootdir May 8, 2024
@sandorkertesz sandorkertesz merged commit 75a419e into develop May 8, 2024
71 checks passed
@sandorkertesz sandorkertesz deleted the feature/pyroject-toml branch May 8, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant