Skip to content
This repository has been archived by the owner on Jul 22, 2020. It is now read-only.

Support changing name and multiplicity of references [8] #72

Closed
planger opened this issue Nov 26, 2019 · 7 comments · Fixed by #99
Closed

Support changing name and multiplicity of references [8] #72

planger opened this issue Nov 26, 2019 · 7 comments · Fixed by #99
Labels
Milestone

Comments

@planger
Copy link
Contributor

planger commented Nov 26, 2019

Maybe I missed the issue when looking through them, but currently, we it is not yet supported to change the name or the multiplicity of references. Labels of references support the direct edit feature too, so we may use it and do this similarly to the attribute name/type changes.

@planger planger added the lab label Nov 26, 2019
@CamilleLetavernier
Copy link
Contributor

Yeah, it's not supported yet; I missed that too :)

@JonasHelming JonasHelming changed the title Support changing name and multiplicity of references Support changing name and multiplicity of references [8] Nov 29, 2019
@JonasHelming
Copy link
Member

Scope for now:
separate the label (multiplicity + name), change multiplicity (with drop down support), rename, no need to change layout for now

@JonasHelming JonasHelming added this to the lab milestone Nov 29, 2019
@planger
Copy link
Contributor Author

planger commented Dec 2, 2019

change multiplicity (with drop down support)

Currently we only have the drop down support for the command palette, but not for rename inputs. It can quite easily be used for rename inputs too in a custom implementation. However, I think, it would be cool to have generic support for suggestions/auto-complete in the form of a drop down for renames as well.
We might need that in another project quite soon, so we might add generic support for that in GLSP in a bit.

@JonasHelming
Copy link
Member

I was thinking of something similar to the EType auto completion which awas recently contributed. Are you saying we might "generify that"?

@planger
Copy link
Contributor Author

planger commented Dec 2, 2019

Ah, you mean #66 right?
I wasn't aware of that. Yes, I meant generifying that.

@leodennis
Copy link
Contributor

What exactly are the allowed multiplicities?
In the eclipse version for lower bound all numbers seem to be valid and for the upper bound also all numbers and -1 for * and -2 for unspecified.
Also should I invest time into #79 to generify the autocomplete?

@JonasHelming
Copy link
Member

Let us not consider "-2" for now and treat "-1" as a synonym for "*"

Actually all other numbers are allowed therefore, I beleive the autcomplete case does not really fits here well. IMHO parsing [a..b] would be good enough

leodennis pushed a commit to jcebel/ecore-glsp that referenced this issue Jan 4, 2020
These changes make it possible to rename references and to change the multiplicity.

Resolves: eclipsesource#72
Signed-off-by: leodennis <[email protected]>
leodennis pushed a commit to jcebel/ecore-glsp that referenced this issue Jan 6, 2020
leodennis pushed a commit to jcebel/ecore-glsp that referenced this issue Jan 9, 2020
These changes make it possible to rename references and to change the multiplicity.

Resolves: eclipsesource#72
Signed-off-by: leodennis <[email protected]>

Added support for literal editing

Added subclasses of SLabelNode for attributes and literals.
Changed EcoreLabelOperationHandler to support server side editing.
Resolves:eclipsesource#61
Signed-off-by: leodennis <[email protected]>

Fix two Typos in the Create New Ecore Command.

Change of structure

Signed-off-by: leodennis <[email protected]>
leodennis pushed a commit to jcebel/ecore-glsp that referenced this issue Jan 9, 2020
These changes make it possible to rename references and to change the multiplicity.

Resolves: eclipsesource#72
Signed-off-by: leodennis <[email protected]>

Added support for literal editing

Added subclasses of SLabelNode for attributes and literals.
Changed EcoreLabelOperationHandler to support server side editing.
Resolves:eclipsesource#61
Signed-off-by: leodennis <[email protected]>

Fix two Typos in the Create New Ecore Command.

Change of structure

Signed-off-by: leodennis <[email protected]>
eneufeld pushed a commit that referenced this issue Jan 9, 2020
These changes make it possible to rename references and to change the multiplicity.

Resolves: #72
Signed-off-by: leodennis <[email protected]>

Added support for literal editing

Added subclasses of SLabelNode for attributes and literals.
Changed EcoreLabelOperationHandler to support server side editing.
Resolves:#61
Signed-off-by: leodennis <[email protected]>

Fix two Typos in the Create New Ecore Command.

Change of structure

Signed-off-by: leodennis <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants