Skip to content
This repository has been archived by the owner on Jul 22, 2020. It is now read-only.

Fix inheritance implementation #103

Open
sgraband opened this issue Jan 8, 2020 · 3 comments
Open

Fix inheritance implementation #103

sgraband opened this issue Jan 8, 2020 · 3 comments
Assignees
@sgraband
Labels
bug Something isn't working diagrams Related to Ecore Diagrams (Editor, visualization & edition)
Milestone
M1: Ecore Diagrams

Comments

@sgraband
Copy link
Collaborator

sgraband commented Jan 8, 2020 •
edited
Loading

Currently you cannot delete inheritance edges, by clicking on them and pressing ENTF/DEL. For the other edge types it is working.

Furthermore, inheritance edges cannot be moved, since there is no representation in the notation files.
@sgraband sgraband mentioned this issue Jan 9, 2020
Merged
@sgraband sgraband changed the title Can´t delete inheritance edges with ENTF Can´t delete inheritance edges with DELETE Jan 14, 2020
@CamilleLetavernier CamilleLetavernier added the diagrams Related to Ecore Diagrams (Editor, visualization & edition) label Mar 6, 2020
@sgraband
Copy link
Collaborator Author

sgraband commented Apr 7, 2020

@CamilleLetavernier should this be added to Milestone 1? Currently you cannot delete inheritance edges at all, and therefore causes the tests to fail.

@sgraband sgraband changed the title Can´t delete inheritance edges with DELETE Can´t delete inheritance edges Apr 7, 2020
@CamilleLetavernier
Copy link
Contributor

Good point, this definitely makes sense

@CamilleLetavernier CamilleLetavernier added the bug Something isn't working label Apr 7, 2020
@CamilleLetavernier CamilleLetavernier added this to the M1: Ecore Diagrams milestone Apr 7, 2020
@sgraband
Copy link
Collaborator Author

sgraband commented Apr 7, 2020

Can you assign this to me? I found some other problems with inheritance that should be fixed, before working on the tests.

@sgraband sgraband changed the title Can´t delete inheritance edges Fix inheritance implementation Apr 14, 2020
sgraband added a commit to sgraband/ecore-glsp that referenced this issue Apr 14, 2020
@sgraband
Update the Testcases + Travis Integration
981f9b1 
Tests now have a seperate workspace for easier execution and to make them more robust. Currently the tests are running in a third Travis Build, next to the maven and yarn builds. However, since the tests require maven and yarn to be run, these tests could be put together in the future.

Right now two tests are failing due to eclipsesource#103.

Signed-off-by: Simon Graband <[email protected]>
@sgraband sgraband mentioned this issue Apr 14, 2020
Open
sgraband added a commit to sgraband/ecore-glsp that referenced this issue Apr 30, 2020
@sgraband
Update the Testcases + Travis Integration
c204d95 
Tests now have a seperate workspace for easier execution and to make them more robust. Currently the tests are running in a third Travis Build, next to the maven and yarn builds. However, since the tests require maven and yarn to be run, these tests could be put together in the future.

Right now two tests are failing due to eclipsesource#103.

Signed-off-by: Simon Graband <[email protected]>
@CamilleLetavernier CamilleLetavernier mentioned this issue Aug 4, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sgraband sgraband

Labels
bug Something isn't working diagrams Related to Ecore Diagrams (Editor, visualization & edition)
Projects
None yet
Milestone
M1: Ecore Diagrams
Development

No branches or pull requests
2 participants
@CamilleLetavernier @sgraband