From 32caeb70facf05c10b7fd3eaeb4727540b704f76 Mon Sep 17 00:00:00 2001 From: EHOAPHA Date: Tue, 11 Jun 2024 11:56:54 -0400 Subject: [PATCH] Continue mirror extension versions even if one fails Currently, the OpenVSX server stops mirroring extension version if one of the versions failed to be mirrored. This commit logs the mirror failure instead of throwing an error. Fixes #923. --- .../java/org/eclipse/openvsx/mirror/MirrorExtensionService.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/src/main/java/org/eclipse/openvsx/mirror/MirrorExtensionService.java b/server/src/main/java/org/eclipse/openvsx/mirror/MirrorExtensionService.java index 1a38b03a2..16bbf5319 100644 --- a/server/src/main/java/org/eclipse/openvsx/mirror/MirrorExtensionService.java +++ b/server/src/main/java/org/eclipse/openvsx/mirror/MirrorExtensionService.java @@ -142,8 +142,8 @@ private void mirrorExtensionVersions(String namespaceName, String extensionName, mirrorExtensionVersion(json); data.getMirroredVersions().increment(); } catch (Throwable t) { + jobContext.logger().info("failure to mirror " + NamingUtil.toLogFormat(json) + " (" + (i+1) + "/" + toAdd.size() + ")"); data.getFailedVersions().increment(); - throw t; } } }