Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Double clicking on XPECT test result does not navigate to XPECT statement #261

Open
trancexpress opened this issue Feb 22, 2019 · 4 comments
Open

Double clicking on XPECT test result does not navigate to XPECT statement #261

trancexpress opened this issue Feb 22, 2019 · 4 comments

Comments

@trancexpress
Copy link
Contributor

With xpect 0.1.0 it was possible to double click on a XPECT entry in the JUnit view. This would then open the DSL test file and select the respective XPECT statement.

With xpect 0.2.0 double clicking on an XPECT entry results in a dialog "Method ... not found. Opening test class". Its still possible to right-click on the entry and choose "Go to XPECT method", however this involves more user interaction.
@trancexpress trancexpress changed the title Douuble clicking on XPECT test result does not navigate to XPECT statement Double clicking on XPECT test result does not navigate to XPECT statement Feb 22, 2019
@trancexpress
Copy link
Contributor Author

Looks like xpect 0.1.0 uses org.xpect.ui.junit.OpenFileAction, which is "registered" when org.xpect.ui.junit.XpectRunnerUIHandler.contextMenuAboutToShow(ViewPart, ITestElement, IMenuManager) is called. I don't find XpectRunnerUIHandler in the xpect 0.2.0 bundles. I do find OpenFileAction in org.eclipse.xpect.ui.junit. However its only used when calling the "Go to XPECT method" menu entry. It doesn't seem to be associated with the "Go to File" entry, which is called on double click.

@trancexpress
Copy link
Contributor Author

Caused by: https://github.com/eclipse/Xpect/pull/229/files

@trancexpress
Copy link
Contributor Author

Created JDT bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=546882

I'm looking into this now.

@trancexpress
Copy link
Contributor Author

This seems to be the original JDT ticket created by Moritz Eysholdt:

https://bugs.eclipse.org/bugs/show_bug.cgi?id=391023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@trancexpress