Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename ZidBuilder #996

Closed
milyin opened this issue Apr 30, 2024 · 1 comment · Fixed by #994
Closed

rename ZidBuilder #996

milyin opened this issue Apr 30, 2024 · 1 comment · Fixed by #994
Labels
release Part of the next release

Comments

@milyin
Copy link
Contributor

milyin commented Apr 30, 2024

Describe the release item

ZidBuilder should be called ZenohIdBuilder since the correct type is ZenohId.
@milyin milyin added the release Part of the next release label Apr 30, 2024
@milyin milyin mentioned this issue Apr 30, 2024
Merged
@Mallets Mallets linked a pull request Apr 30, 2024 that will close this issue
Fix #996. Rename ZidBuilder to ZenohIdBuilder. #994
Merged
@Mallets Mallets mentioned this issue Apr 30, 2024
Merged
@Mallets
Copy link
Member

Mallets commented May 2, 2024

Merged into protocol_changes. It will eventually land in main.

@Mallets Mallets closed this as completed May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
release Part of the next release
Projects
Zenoh 1.0.0 release
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #996. Rename ZidBuilder to ZenohIdBuilder. eclipse-zenoh/zenoh
2 participants
@milyin @Mallets