Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runtime Agnostic #91

Closed
teburd opened this issue May 12, 2021 · 2 comments
Closed

Runtime Agnostic #91

teburd opened this issue May 12, 2021 · 2 comments
Labels
enhancement Existing things could work better

Comments

@teburd
Copy link

teburd commented May 12, 2021

SQLx managed to avoid locking themselves to tokio/async-std/smol or whatever seemingly by creating a small feature flag driven crate of about 200 loc.

It would be nice to avoid locking this directly to async-std, even if there is a compatibility layer.

https://github.com/launchbadge/sqlx/blob/master/sqlx-rt/src/lib.rs

@teburd teburd changed the title Runtime Agnostic I/O Runtime Agnostic May 12, 2021
@kydos
Copy link
Member

kydos commented Jun 23, 2021

Thanks for the suggestion @BFrog we'll look into that. We did look closely into Tokio and the main reason for us to pick async-std was that the Sockets have inner mutability. In Tokio there is a split to separate reader and writer half, but the way in which lifetimes work makes it hard to use w/o adding a mutex...

@Mallets Mallets added the enhancement Existing things could work better label Feb 15, 2022
@Mallets Mallets moved this to Q4 2022 - Oct-Dec in Zenoh Roadmap Apr 4, 2022
@Mallets Mallets moved this from Q4 2022 - Oct-Dec to Q1 2023 - Jan-Mar in Zenoh Roadmap Apr 4, 2022
@Mallets Mallets assigned Mallets and p-avital and unassigned Mallets and p-avital Apr 4, 2022
@Mallets Mallets removed this from Zenoh Roadmap Apr 6, 2022
@teburd
Copy link
Author

teburd commented Apr 3, 2024

@Mallets I believe this can be closed with #566

@teburd teburd closed this as completed Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Existing things could work better
Projects
None yet
Development

No branches or pull requests

4 participants