Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support priority in get & queryable #750

Closed
evshary opened this issue Feb 22, 2024 · 1 comment
Closed

Support priority in get & queryable #750

evshary opened this issue Feb 22, 2024 · 1 comment
Labels
api sync Synchronize API with other bindings enhancement Existing things could work better

Comments

@evshary
Copy link
Contributor

evshary commented Feb 22, 2024

Describe the feature

Now Zenoh supports setting priority in PutBuilder
https://docs.rs/zenoh/0.10.1-rc/zenoh/publication/struct.PutBuilder.html#method.priority
However, we don't have a similar function in GetBuilder.
https://docs.rs/zenoh/0.10.1-rc/zenoh/query/struct.GetBuilder.html
In uProtocol integration, we need the priority mechanism in both Pub/Sub and RPC scenarios.
It would be better to support the priority mechanism in GetBuilder.

Also, we need to obtain the priority on the queryable side, which is similar to the PR for implementing similar functions on the subscriber side.
#730

@evshary evshary added the new feature Something new is needed label Feb 22, 2024
@milyin milyin moved this to Backlog in Zenoh 1.0.0 release Feb 22, 2024
@milyin milyin added api sync Synchronize API with other bindings enhancement Existing things could work better and removed new feature Something new is needed labels Mar 12, 2024
@Mallets Mallets mentioned this issue Mar 14, 2024
3 tasks
@milyin
Copy link
Contributor

milyin commented Mar 27, 2024

Already done in protocol_changes branch. Systematic API for setting these options introduced in PR #858

@milyin milyin closed this as completed Mar 27, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Done in Zenoh 1.0.0 release Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api sync Synchronize API with other bindings enhancement Existing things could work better
Projects
Status: Done
Development

No branches or pull requests

2 participants