Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write in Rust Publisher should be moved to a trait #731

Closed
DenisBiryukov91 opened this issue Feb 12, 2024 · 1 comment · Fixed by #736 or #819
Closed

Write in Rust Publisher should be moved to a trait #731

DenisBiryukov91 opened this issue Feb 12, 2024 · 1 comment · Fixed by #736 or #819
Assignees
@DenisBiryukov91
Labels
enhancement Existing things could work better release Part of the next release

Comments

@DenisBiryukov91
Copy link
Contributor

Describe the release item

Publisher.write function is required to implement the stream functionality in Rust, it is not part of the “core” API. It should be moved in a trait.
@DenisBiryukov91 DenisBiryukov91 added the release Part of the next release label Feb 12, 2024
@milyin milyin moved this to In progress in Zenoh 1.0.0 release Feb 12, 2024
@milyin milyin added the enhancement Existing things could work better label Feb 12, 2024
@DenisBiryukov91 DenisBiryukov91 mentioned this issue Feb 13, 2024
Merged
@milyin
Copy link
Contributor

milyin commented Mar 12, 2024

Closing this issue should also close #650

@milyin milyin mentioned this issue Mar 13, 2024
Merged
@milyin milyin linked a pull request Mar 13, 2024 that will close this issue
remove Publisher::write #819
Merged
@github-project-automation github-project-automation bot moved this from In progress to Done in Zenoh 1.0.0 release Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DenisBiryukov91 DenisBiryukov91

Labels
enhancement Existing things could work better release Part of the next release
Projects
Zenoh 1.0.0 release
Status: Done
Milestone
No milestone
2 participants
@milyin @DenisBiryukov91