Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing no_mangle feature in zenoh-plugin-trait breaks zenoh-plugin-mqtt #675

Closed
fuzzypixelz opened this issue Jan 25, 2024 · 1 comment
Closed
Assignees
Labels
bug Something isn't working release Part of the next release

Comments

@fuzzypixelz
Copy link
Member

Describe the release item

The sync-lockfiles.yml workflow currently fails with the following error:

error: failed to select a version for `zenoh-plugin-trait`.
    ... required by package `zenoh-plugin-mqtt v0.11.0-dev (/home/runner/work/zenoh/zenoh/zenoh-plugin-mqtt)`
    ... which satisfies path dependency `zenoh-plugin-mqtt` of package `zenoh-bridge-mqtt v0.11.0-dev (/home/runner/work/zenoh/zenoh/zenoh-bridge-mqtt)`
versions that meet the requirements `^0.11.0-dev` are: 0.11.0-dev

the package `zenoh-plugin-mqtt` depends on `zenoh-plugin-trait`, with features: `no_mangle` but `zenoh-plugin-trait` does not have these features.

This due to the no_mangle feature removal in #583.

@fuzzypixelz fuzzypixelz added the release Part of the next release label Jan 25, 2024
@milyin milyin self-assigned this Jan 26, 2024
@milyin milyin added the bug Something isn't working label Jan 26, 2024
@milyin milyin moved this to In progress in Zenoh 1.0.0 release Jan 26, 2024
@milyin
Copy link
Contributor

milyin commented Mar 12, 2024

Not reproduced anymore. Though two other existing failures in sync-lockfiles were addressed:
eclipse-zenoh/zenoh-plugin-ros1#36
eclipse-zenoh/zenoh-plugin-ros2dds#89

@milyin milyin closed this as completed Mar 12, 2024
@github-project-automation github-project-automation bot moved this from In progress to Done in Zenoh 1.0.0 release Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working release Part of the next release
Projects
Status: Done
Development

No branches or pull requests

2 participants