Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: Typos and clarifications #1387

Closed
awesomebytes opened this issue Sep 10, 2024 · 2 comments
Closed

Documentation: Typos and clarifications #1387

awesomebytes opened this issue Sep 10, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@awesomebytes
Copy link

Describe the bug

Hello, given I can't find a repo with the documentation to do a PR directly, I may as well point out minor typos I found when reading the docs.

Zenoh applications in peer mode forward all local applications and router they already discovered to newly scouted applications.

router -> routers

they already discovered -> they have already discovered

The key space of Zenoh dedicate to administer a Zenoh router and its plugins. It is accessible via regular get/put on Zenoh,

dedicate -> dedicated

administer -> administering

get/put -> GET/PUT (to follow the rest of the docs)

Then you can change elements of it’s configuration once it’s started, by sending put messages to its admin space.

put -> PUT

Note that while you may attempt to change any part of the configuration through this mean, not all of its properties are actually watched.
For example, while the storage plugin watches for any change in its configuration and will attempt to act on it, the REST plugin will only log a warning that it observed a change, but won’t apply it.
Changes to non-plugin parts of the configuration may be registered by the configuration, but not acted upon, such as the mode field of the configuration which is only ever read at startup.

Not really a typo, but I found this explanation pretty confusing. Maybe a list or diagram of "Watched properties and how they are acted upon changes" would help.

Through configuration:: you may also

Double ":"

TODO: this part hasn’t been redocumented yet. Feel free to contact us on Discord to get more information.

Well, it's a TODO, just thought I'd bring it up.

[1] Off-topic: In https://zenoh.io/docs/getting-started/troubleshooting/ it says that: "Error treating timestamp for received Data" may appear if there is a discrepancy in between clocks of 100ms. When teaching ROS to students, specially in environments without access to the internet, just a local network, drifts in the clock were a relatively common issue. By using messages without a timestamp, we could overcome teaching the basics ignoring these kind of problems. Is there a way to ignore timestamps in zenoh? Or tune the discrepancy?

To reproduce

Open the docs, read them.

System info

Windows 11, Firefox, it doesn't really matter.

@awesomebytes awesomebytes added the bug Something isn't working label Sep 10, 2024
@JEnoch
Copy link
Member

JEnoch commented Sep 10, 2024

Thanks for reviewing this!
The web site repo is here: https://github.com/atolab/zenoh-web
With all the pages as Markdown files under content/
Do you mind creating a PR in here ?

@awesomebytes
Copy link
Author

Thanks for pointing to that repo @JEnoch I moved the issue there (atolab/zenoh-web#58) and did a PR with what I could fix (atolab/zenoh-web#57).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants