Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failure to undeclare Liveliness Subscribers #1282

Closed
fuzzypixelz opened this issue Jul 30, 2024 · 1 comment
Closed

Failure to undeclare Liveliness Subscribers #1282

fuzzypixelz opened this issue Jul 30, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@fuzzypixelz
Copy link
Member

Describe the bug

zenoh/zenoh/src/api/session.rs

Lines 1239 to 1243 in 502d3be

pub(crate) fn undeclare_subscriber_inner(&self, sid: Id, kind: SubscriberKind) -> ZResult<()> {
let mut state = zwrite!(self.state);
if let Some(sub_state) = state
.subscribers_mut(SubscriberKind::Subscriber)
.remove(&sid)

Only non-Liveliness Subscribers are checked.

To reproduce

  1. Declare a Liveliness Subscriber
  2. Undeclare it.

System info

@fuzzypixelz fuzzypixelz added the bug Something isn't working label Jul 30, 2024
@YuanYuYuan
Copy link
Contributor

Relevant issue ZettaScaleLabs/rmw_zenoh#2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants