Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev/1.0.0]Fix EntityGlobalId #1203

Open
wyfo opened this issue Jun 28, 2024 · 2 comments
Open

[dev/1.0.0]Fix EntityGlobalId #1203

wyfo opened this issue Jun 28, 2024 · 2 comments
Labels
api fix Correct API

Comments

@wyfo
Copy link
Contributor

wyfo commented Jun 28, 2024

Describe the release item

There is no current way to have a EntityGlobalId corresponding to a Session, so it's not possible to have a SourceInfo corresponding to a Session.
As discussed with @OlivierHecart, Session should have an EntityId, which may be 0, or not in the case of multiple session sharing a same runtime (e.g. plugins).

Also, according to @OlivierHecart, we may want Reply::replier_id to be an EntityGlobalId instead of a ZenohId.

@Mallets @milyin What do you think?

@wyfo wyfo added the release Part of the next release label Jun 28, 2024
@Mallets
Copy link
Member

Mallets commented Jul 4, 2024

I think the proposal makes sense. +1

@milyin milyin assigned milyin and unassigned milyin Jul 5, 2024
@milyin
Copy link
Contributor

milyin commented Jul 5, 2024

replier_id is declared unstable now, so this issue is not a priority. Source info is unstable too
#709

@milyin milyin added api fix Correct API and removed release Part of the next release labels Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api fix Correct API
Projects
Status: No status
Development

No branches or pull requests

3 participants