From d0f08e86505fab4d2c21bb5574336b942330ed62 Mon Sep 17 00:00:00 2001 From: OlivierHecart Date: Fri, 8 Sep 2023 10:16:51 +0200 Subject: [PATCH] Do not send sub declarations to multicast on windows --- zenoh/src/net/routing/pubsub.rs | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/zenoh/src/net/routing/pubsub.rs b/zenoh/src/net/routing/pubsub.rs index ac61022404..e31df26b59 100644 --- a/zenoh/src/net/routing/pubsub.rs +++ b/zenoh/src/net/routing/pubsub.rs @@ -464,6 +464,9 @@ pub fn declare_client_subscription( ); } else { propagate_simple_subscription(&mut wtables, &res, &propa_sub_info, face); + // This introduced a buffer overflow on windows + // TODO: Let's deactivate this on windows until Fixed + #[cfg(not(windows))] for mcast_group in &wtables.mcast_groups { mcast_group.primitives.send_declare(Declare { ext_qos: ext::QoSType::default(), @@ -480,6 +483,9 @@ pub fn declare_client_subscription( } _ => { propagate_simple_subscription(&mut wtables, &res, &propa_sub_info, face); + // This introduced a buffer overflow on windows + // TODO: Let's deactivate this on windows until Fixed + #[cfg(not(windows))] for mcast_group in &wtables.mcast_groups { mcast_group.primitives.send_declare(Declare { ext_qos: ext::QoSType::default(),