You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is it on purpose that the option of passing a tuple as session.get handler no longer works in 1.0.0?
Instead it is necessary to wrap it into a handlers.Callback (i expected that this would happen automatically)
IMHO that's an unnecessary breaking change and I could not find any documentation about this change.
At least this should be documented in the 0.11.0 -> 1.0.0 migration section. Thanks :-)
fsteff
changed the title
[Bug/Breaking Change] session.get tuple callback no longer works
[Bug/Breaking Change] session.get tuple callback no longer works in 1.0.0
Oct 18, 2024
The Python bindings have been rewritten from scratch for 1.0, trying to match more carefully the Rust API. In Rust, a tuple handler has the meaning (callback, handler), not (callback, done_callback).
I think it's too late to rollback to the old behavior, but that's indeed a breaking change that should be mentioned in bold in the migration guide.
P.S. Looking again at the 0.11 version, the signature was quite confusing IMO, as you were able to pass a tuple (closure, receiver), but also a tuple (callback, done_callback). So I would say the change was for the better, but I acknowledge that it's annoying.
Describe the bug
Is it on purpose that the option of passing a tuple as session.get handler no longer works in 1.0.0?
Instead it is necessary to wrap it into a
handlers.Callback
(i expected that this would happen automatically)IMHO that's an unnecessary breaking change and I could not find any documentation about this change.
At least this should be documented in the 0.11.0 -> 1.0.0 migration section. Thanks :-)
To reproduce
result: only "reply" is written to the console
workaround / breaking change :
System info
1.0.0-rc.2
The text was updated successfully, but these errors were encountered: