Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the option to fetch the paramters as Map from Selector #64

Closed
vanny96 opened this issue Apr 6, 2024 · 1 comment
Closed

Add the option to fetch the paramters as Map from Selector #64

vanny96 opened this issue Apr 6, 2024 · 1 comment

Comments

@vanny96
Copy link
Contributor

vanny96 commented Apr 6, 2024

Describe the feature

The rust API for the Selector class allows to retrieve the paramaters as a map with the parameters_map method. It would be nice to have such a feature in the kotlin API.

This could be implemented either through the JNI, reusing the existing logic used in Rust, or reimplemented in Kotlin using libraries such as httpcomponents-client.

Any opinions on this?

vanny96 added a commit to vanny96/zenoh-kotlin that referenced this issue Apr 6, 2024
vanny96 added a commit to vanny96/zenoh-kotlin that referenced this issue Apr 6, 2024
vanny96 added a commit to vanny96/zenoh-kotlin that referenced this issue Apr 6, 2024
@DariusIMP
Copy link
Member

Hi! Thanks for reporting this, indeed that's one of the features that are missing. There are a couple of other functionalities on the Selector that need to be implemented, I opened issue #67 for that.

or reimplemented in Kotlin using libraries such as httpcomponents-client

I'd rather minimize the reliance on external libs if possible. I haven't yet reviewed your PR, will do so now :)

vanny96 added a commit to vanny96/zenoh-kotlin that referenced this issue May 14, 2024
vanny96 added a commit to vanny96/zenoh-kotlin that referenced this issue May 14, 2024
vanny96 added a commit to vanny96/zenoh-kotlin that referenced this issue May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants