-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lowering required CMake version for Ubuntu 20.04? #7
Comments
Fixed by #9. CMake version is now set to 3.16. |
I've tested this and it does not work. The error that I get is: My suggestion is to revert the change and go back to CMake 3.21 (for now) since that works. |
Yes, I've also encountered the same problem yesterday after the version rollback. The fix was to use absolute path in CMAKE_INSTALL_PREFIX - seems that old version of cmake treats relative path as relative to CMakeLists.txt location and newer version treats is as relative to current build directory. |
That's strange. I used /home/username/local (to avoid working on root) both for zenoh-c and zenoh-cpp and it worked. I'll check it again |
I tried the following just now: (username is my own user name)
This results in the error:
I'm using Ubuntu 20.04 with CMake 3.16.3 |
For me this sequence works well on mac (cmake 3.25.1), Ubuntu 22.04 (cmake 3.22.1), Ubuntu 20.04 (cmake 3.23.2). |
I think it's a problem with CMake 3.16. It can be solved by editing zenohcConfig.cmake that is generated when compiling zenoh-c. Lines 41 and 45 have the functions I will try to change the generation of those files in zenoh-c and upload them as a pull request. |
Closes #111 resolves eclipse-zenoh/zenoh-cpp#7
Real cmake 3.16 doesn't work with current cmake files, despite that 3.20 works ok with 3.16 mode. |
Fixed in #75 |
The required cmake version for this repo is set to 3.21.
The package manager in Ubuntu 20.04LTS has cmake version 3.16. The required cmake version for Zenoh-C is version 3.10.
My question is; is 3.21 a deliberate choice? If not, could it be set to 3.16 so we don't have to recompile cmake on Ubuntu 20.04?
The text was updated successfully, but these errors were encountered: