Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmakelists.txt doesn't work well with ros2 build system #188

Closed
milyin opened this issue Aug 27, 2024 · 1 comment
Closed

cmakelists.txt doesn't work well with ros2 build system #188

milyin opened this issue Aug 27, 2024 · 1 comment
Labels
release Part of the next release

Comments

@milyin
Copy link
Contributor

milyin commented Aug 27, 2024

Describe the release item

ROS2 uses build system https://docs.ros.org/en/foxy/How-To-Guides/Ament-CMake-Documentation.html
The CMakeLists files and packages installed by them should be compatible. It would be good also to add tests to ensure this compatibility

The issue was reported by @YuanYuYuan, @DenisBiryukov91 is working on it now
@milyin milyin added the release Part of the next release label Aug 27, 2024
@milyin milyin changed the title cmake doesn't work well with ros2 build system cmakelists.txt doesn't work well with ros2 build system Aug 27, 2024
@milyin milyin mentioned this issue Aug 29, 2024
Merged
@milyin
Copy link
Contributor Author

milyin commented Sep 4, 2024

Fixed in eclipse-zenoh/zenoh-c#629

@milyin milyin closed this as completed Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
release Part of the next release
Projects
Zenoh 1.0.0 release
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@milyin