Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documnetation page about zenoh-c types concepts #690

Merged
merged 4 commits into from
Sep 17, 2024
Merged

Conversation

milyin
Copy link
Contributor

@milyin milyin commented Sep 14, 2024

closes
#651
#490

Copy link

PR missing one of the required labels: {'new feature', 'internal', 'bug', 'dependencies', 'documentation', 'breaking-change', 'enhancement'}

@milyin milyin added the documentation Improvements or additions to documentation label Sep 14, 2024
@milyin milyin requested review from sashacmc and Mallets September 14, 2024 19:22
Copy link
Member

@sashacmc sashacmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small notes, others LGTM

docs/concepts.rst Outdated Show resolved Hide resolved
Enums and Plain Data Structures `z_xxx_t`
-----------------------------------------

Types named `z_xxx_t` are simple, copyable, and can be passed by value. They do not have special handling.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also POD?

docs/concepts.rst Outdated Show resolved Hide resolved
docs/concepts.rst Outdated Show resolved Hide resolved
docs/concepts.rst Outdated Show resolved Hide resolved
docs/concepts.rst Outdated Show resolved Hide resolved
Co-authored-by: Alexander Bushnev <[email protected]>
@yellowhatter yellowhatter enabled auto-merge (squash) September 17, 2024 13:20
@yellowhatter yellowhatter merged commit 7eb0509 into main Sep 17, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants