Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename feature macros #688

Closed
DenisBiryukov91 opened this issue Sep 13, 2024 · 0 comments
Closed

rename feature macros #688

DenisBiryukov91 opened this issue Sep 13, 2024 · 0 comments
Labels
release Part of the next release

Comments

@DenisBiryukov91
Copy link
Contributor

DenisBiryukov91 commented Sep 13, 2024

Describe the release item

Currently we are using UNSTABLE to check for unstable feature and SHARED_MEMORY for shared memory feature. These are pretty common names, to avoid collisions with other libraries we need to change them somehow. One proposal is to use schema similar to zenoh pico, where everything is prefixed with Z_FEATURE i.e. this would translate into:
Z_FEATURE_UNSTABLE_API and Z_FEATURE_SHARED_MEMORY.

It is also desirable to make same updated for platform dependent macros, i.e:
TARGET_ARCH_AARCH64 -> Z_TARGET_ARCH_AARCH64.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Part of the next release
Projects
Status: Done
Development

No branches or pull requests

1 participant