Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename "callback" variables/parameters #491

Closed
milyin opened this issue Jul 2, 2024 · 1 comment
Closed

rename "callback" variables/parameters #491

milyin opened this issue Jul 2, 2024 · 1 comment
Labels
documentation Improvements or additions to documentation

Comments

@milyin
Copy link
Contributor

milyin commented Jul 2, 2024

Describe the release item

The structures are named "closure" and the closure have fields "context", "callback" and "drop"
@YuanYuYuan noticed that as the function's parameters and variable names are named "callback" too, this confuses user.

Maybe we should consider some renaming -e.g. name this parameter "closure" ?

@milyin milyin added the release Part of the next release label Jul 2, 2024
@milyin milyin added documentation Improvements or additions to documentation and removed release Part of the next release labels Jul 2, 2024
@milyin
Copy link
Contributor Author

milyin commented Oct 15, 2024

After some discussion month ago the good soultion was not found. Since the word "callback" is used in Rust API, better to not to do renaming of the parameter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Status: Done
Development

No branches or pull requests

1 participant