Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename zc_owned_liveliness_get_options_t to zc_liveliness_get_options_t #281

Closed
milyin opened this issue Mar 11, 2024 · 2 comments · Fixed by #290
Closed

rename zc_owned_liveliness_get_options_t to zc_liveliness_get_options_t #281

milyin opened this issue Mar 11, 2024 · 2 comments · Fixed by #290
Assignees
Labels
api sync Synchronize API with other bindings

Comments

@milyin
Copy link
Contributor

milyin commented Mar 11, 2024

Describe the release item

The owned prefix is intended to mark structures which holds reference to external memory / resource. They should be either "moved" or "loaned", keeping single instance responsable for deletion of the data.
This is not the case for options structure - it can be copied freely

@milyin milyin added the release Part of the next release label Mar 11, 2024
@milyin
Copy link
Contributor Author

milyin commented Mar 11, 2024

Also it's need to be checked, are we going to support this in zenoh-pico? If yes, it prefix should be just z_

@sashacmc
Copy link
Member

Please assign it to me

@milyin milyin moved this to Backlog in Zenoh 1.0.0 release Mar 12, 2024
@milyin milyin added api sync Synchronize API with other bindings and removed release Part of the next release labels Mar 12, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Done in Zenoh 1.0.0 release Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api sync Synchronize API with other bindings
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants