Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider exposing WhatAmI as a separate type and provide to_str api #271

Closed
DenisBiryukov91 opened this issue Mar 8, 2024 · 1 comment · Fixed by #284
Closed

Consider exposing WhatAmI as a separate type and provide to_str api #271

DenisBiryukov91 opened this issue Mar 8, 2024 · 1 comment · Fixed by #284
Labels
api sync Synchronize API with other bindings

Comments

@DenisBiryukov91
Copy link
Contributor

Describe the release item

WhatAmI is currently exposed as uint32.
We should consider exposing it as a separate type and also provide to_str method, similar to what we have in Rust.
@DenisBiryukov91 DenisBiryukov91 added the release Part of the next release label Mar 8, 2024
@milyin milyin moved this to Backlog in Zenoh 1.0.0 release Mar 12, 2024
@milyin milyin added api sync Synchronize API with other bindings and removed release Part of the next release labels Mar 12, 2024
@DenisBiryukov91 DenisBiryukov91 mentioned this issue Mar 12, 2024
Merged
@milyin
Copy link
Contributor

milyin commented Mar 14, 2024

Keep it as is for now. Adding to_str is low priority

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api sync Synchronize API with other bindings
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add z_whatami_to_str api DenisBiryukov91/zenoh-c
2 participants
@milyin @DenisBiryukov91