Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extensions should accept a configuration #249

Open
J-Loudet opened this issue May 3, 2024 · 0 comments
Open

Extensions should accept a configuration #249

J-Loudet opened this issue May 3, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@J-Loudet
Copy link
Contributor

J-Loudet commented May 3, 2024

In order to not require users to install globally (via the --break-system-packages flag) the Python library of Zenoh-Flow, the path to this library should be provided in the extension.

At the same time, we want the extension to remain generic. Hence we propose to change its structure and accept, much like the nodes, an optional "configuration": a set of key value pairs.

Extensions would then be written as:

extensions:
- py:
  libraries:
    - source: path/to/shared.so
    - operator: path/to/shared.so
    - sink: path/to/shared.so
  configuration:
    wheel: path/to/python.whl

The one drawback of this proposal is that, in its current state, when validating the libraries Zenoh-Flow only verifies if they were compiled with the same version of the rust compiler and Zenoh-Flow. An incomplete configuration would only be detected at runtime.

@J-Loudet J-Loudet added bug Something isn't working enhancement New feature or request and removed bug Something isn't working labels May 3, 2024
@J-Loudet J-Loudet changed the title [Bug] Extensions should accept a configuration Extensions should accept a configuration May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant