From a0c94e45077b9980c7f822f5802c7b0a0ec11092 Mon Sep 17 00:00:00 2001
From: Hannes Wellmann <wellmann.hannes1@gmx.net>
Date: Sun, 11 Aug 2024 22:51:51 +0200
Subject: [PATCH] [Build] Always collect test-results and don't fail on
 test-failures

The 'Publish Unit Test Results' introduced with
https://github.com/eclipse/xtext/pull/3144
will fail if test-failures are found.
---
 .github/workflows/maven.yml | 20 ++++++++++++++++----
 1 file changed, 16 insertions(+), 4 deletions(-)

diff --git a/.github/workflows/maven.yml b/.github/workflows/maven.yml
index e4404d0db6c..3700523f011 100644
--- a/.github/workflows/maven.yml
+++ b/.github/workflows/maven.yml
@@ -50,11 +50,17 @@ jobs:
       - name: Build and test
         uses: coactions/setup-xvfb@v1.0.1
         with: 
-          run: ./mvnw clean verify -B -fae "-Dmaven.home=${{ env.MAVEN_WRAPPER_HOME }}" -PuseJenkinsSnapshots ${{ matrix.additional-maven-args }} -f org.eclipse.xtext.full.releng
+          run: >
+            ./mvnw "-Dmaven.home=${{ env.MAVEN_WRAPPER_HOME }}"
+            clean verify
+            -f org.eclipse.xtext.full.releng
+            -B -fae -PuseJenkinsSnapshots
+            -Dmaven.test.failure.ignore=true
+            ${{ matrix.additional-maven-args }}
 
       - name: Archive Test Results
         uses: actions/upload-artifact@v4
-        if: ${{ failure() || cancelled() }}
+        if: always()
         with:
           name: test-results-${{ runner.os }}
           path: '**/*.tests/target/surefire-reports'
@@ -89,11 +95,17 @@ jobs:
         run: echo "MAVEN_WRAPPER_HOME=$(./mvnw --version | grep "Maven home:" | cut -c 13-)" >> "$GITHUB_ENV"
 
       - name: Build Maven artifacts
-        run: ./mvnw clean verify -B -fae "-Dmaven.home=${{ env.MAVEN_WRAPPER_HOME }}" -PuseJenkinsSnapshots -Pstrict-jdk-21 -f org.eclipse.xtext.maven.releng
+        run: >
+          ./mvnw "-Dmaven.home=${{ env.MAVEN_WRAPPER_HOME }}"
+          clean verify
+          -f org.eclipse.xtext.maven.releng
+          -B -fae -PuseJenkinsSnapshots
+          -Dmaven.test.failure.ignore=true
+          -Pstrict-jdk-21
 
       - name: Archive Test Results
         uses: actions/upload-artifact@v4
-        if: ${{ failure() || cancelled() }}
+        if: always()
         with:
           name: test-results-${{ runner.os }}
           path: '**/target/surefire-reports'