Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend cpp model with node type and small int types #58

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Extend cpp model with node type and small int types #58

wants to merge 5 commits into from

Conversation

BjoernAtBosch
Copy link
Member

Describe your changes

Issue ticket number and link

Checklist before requesting a review

  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics?
  • Will this be part of a product update? If yes, please write one phrase about this update.

@BjoernAtBosch BjoernAtBosch changed the title Extend cpp model Extend cpp model with node type and small int types Nov 20, 2024
erikbosch
erikbosch approved these changes Nov 21, 2024
View reviewed changes
Copy link

@erikbosch erikbosch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still draft, but looks good so far.

@BjoernAtBosch BjoernAtBosch marked this pull request as ready for review November 27, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikbosch erikbosch erikbosch approved these changes

@MP91 MP91 Awaiting requested review from MP91

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BjoernAtBosch @erikbosch