Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clang-tidy: CallbackConnection.h - Variable conversion issues with return value from InvokeResult #272

Open
billpittman opened this issue Aug 7, 2024 · 1 comment
Labels
quality Code quality and linter issues

Comments

@billpittman
Copy link
Contributor

Just showing the errors since it is probably an easy change:

/data/ultifi/up-cpp/test/coverage/datamodel/UuidValidatorTest.cpp:101:11: error: implicit conversion changes signedness: 'std::chrono::duration<long, std::ratio<1, 1000>>::rep' (aka 'long') to 'uint64_t' (aka 'unsigned long') [clang-diagnostic-sign-conversion]
/data/ultifi/up-cpp/test/coverage/datamodel/UuidValidatorTest.cpp:117:11: error: implicit conversion changes signedness: 'std::chrono::duration<long, std::ratio<1, 1000>>::rep' (aka 'long') to 'uint64_t' (aka 'unsigned long') [clang-diagnostic-sign-conversion]
/data/ultifi/up-cpp/test/coverage/datamodel/UuidValidatorTest.cpp:132:11: error: implicit conversion changes signedness: 'std::chrono::duration<long, std::ratio<1, 1000>>::rep' (aka 'long') to 'uint64_t' (aka 'unsigned long') [clang-diagnostic-sign-conversion]
/data/ultifi/up-cpp/test/coverage/datamodel/UuidValidatorTest.cpp:156:54: error: implicit conversion changes signedness: 'std::chrono::duration<long, std::ratio<1, 1000>>::rep' (aka 'long') to 'uint64_t' (aka 'unsigned long') [clang-diagnostic-sign-conversion]
/data/ultifi/up-cpp/test/coverage/datamodel/UuidValidatorTest.cpp:170:28: error: implicit conversion changes signedness: 'std::chrono::duration<long, std::ratio<1, 1000>>::rep' (aka 'long') to 'uint64_t' (aka 'unsigned long') [clang-diagnostic-sign-conversion]
/data/ultifi/up-cpp/test/coverage/datamodel/UuidValidatorTest.cpp:192:28: error: implicit conversion changes signedness: 'std::chrono::duration<long, std::ratio<1, 1000>>::rep' (aka 'long') to 'uint64_t' (aka 'unsigned long') [clang-diagnostic-sign-conversion]
/data/ultifi/up-cpp/test/coverage/datamodel/UuidValidatorTest.cpp:216:11: error: implicit conversion changes signedness: 'std::chrono::duration<long, std::ratio<1, 1000>>::rep' (aka 'long') to 'uint64_t' (aka 'unsigned long') [clang-diagnostic-sign-conversion]
/data/ultifi/up-cpp/test/coverage/datamodel/UuidValidatorTest.cpp:229:11: error: implicit conversion changes signedness: 'std::chrono::duration<long, std::ratio<1, 1000>>::rep' (aka 'long') to 'uint64_t' (aka 'unsigned long') [clang-diagnostic-sign-conversion]

@gregmedd gregmedd added help wanted Extra attention is needed quality Code quality and linter issues and removed help wanted Extra attention is needed labels Aug 9, 2024
@gregmedd
Copy link
Contributor

gregmedd commented Aug 9, 2024

@billpittman - it looks like the wrong error log got copied here. Any chance you have the right one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
quality Code quality and linter issues
Projects
Status: Backlog
Development

No branches or pull requests

2 participants