Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clang-tidy: UuidBuilderTest - signedness changes #270

Open
billpittman opened this issue Aug 7, 2024 · 1 comment · May be fixed by #295
Open

clang-tidy: UuidBuilderTest - signedness changes #270

billpittman opened this issue Aug 7, 2024 · 1 comment · May be fixed by #295
Assignees
@billpittman
Labels
quality Code quality and linter issues
Milestone
alpha.4

Comments

@billpittman
Copy link
Contributor

Just showing the error output:

/data/ultifi/up-cpp/test/coverage/datamodel/UuidBuilderTest.cpp:73:12: error: implicit conversion changes signedness: 'long' to 'unsigned long' [clang-diagnostic-sign-conversion]
/data/ultifi/up-cpp/test/coverage/datamodel/UuidBuilderTest.cpp:75:12: error: implicit conversion changes signedness: 'long' to 'unsigned long' [clang-diagnostic-sign-conversion]
@gregmedd gregmedd added help wanted Extra attention is needed quality Code quality and linter issues and removed help wanted Extra attention is needed labels Aug 9, 2024
@gregmedd
Copy link
Contributor

gregmedd commented Aug 9, 2024

#271 can probably be resolved at the same time

@gregmedd gregmedd added this to the alpha.4 milestone Aug 12, 2024
@billpittman billpittman self-assigned this Aug 15, 2024
@billpittman billpittman linked a pull request Aug 15, 2024 that will close this issue
Open
@billpittman billpittman moved this from Backlog to In review in C++ uProtocol Development Aug 15, 2024
@gregmedd gregmedd linked a pull request Aug 15, 2024 that will close this issue
UuidBuilderTest.cpp: Use excplicit type not auto #295
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@billpittman billpittman

Labels
quality Code quality and linter issues
Projects
C++ uProtocol Development
Status: In review
Milestone
alpha.4
Development

Successfully merging a pull request may close this issue.

UuidBuilderTest.cpp: Use excplicit type not auto billpittman/up-cpp
2 participants
@billpittman @gregmedd