-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API Tools Plugin should fail the build if the baseline resolution fails #3570
Comments
@Kummallinen do you like to propose a PR that makes this configurable? At best combined with an integration-test to demonstrate the issue so we can make sure it doesn't break in the future. |
@laeubi I can do that, busy with other stuff at the moment so will probably be a few weeks |
Kummallinen
added a commit
to Kummallinen/eclipse-tycho
that referenced
this issue
Apr 8, 2024
Kummallinen
added a commit
to Kummallinen/eclipse-tycho
that referenced
this issue
Apr 8, 2024
Kummallinen
added a commit
to Kummallinen/eclipse-tycho
that referenced
this issue
Apr 8, 2024
Kummallinen
added a commit
to Kummallinen/eclipse-tycho
that referenced
this issue
Apr 8, 2024
Kummallinen
added a commit
to Kummallinen/eclipse-tycho
that referenced
this issue
Apr 8, 2024
laeubi
pushed a commit
that referenced
this issue
Apr 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The current API Tools Plugin only prints a warning if the API baseline resolution fails.
I don't think it should be expected that developers or code reviewers search though the build logs every time to verify the API checks actually ran. This should be considered a fatal error, or at least configurable to be if you want to keep the current behaviour as default.
PDE based tooling would fail the build on a API baseline resolution failure.
Caused by
tycho/tycho-apitools-plugin/src/main/java/org/eclipse/tycho/apitools/ApiAnalysisMojo.java
Line 163 in f4752ed
The text was updated successfully, but these errors were encountered: