Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move p2 dependency tree logic from tycho-p2-plugin to tycho-core #3417

Merged
merged 1 commit into from
Jan 27, 2024

Conversation

ptziegler
Copy link
Contributor

This moves the algorithm which is responsible for calculating the IU dependency tree used by the dependency-tree Mojo to tycho-core, so that it can be used by other projects.

For a given project, this tree can be calculated using the P2DependencyTreeGenerator, which can be injected into a Mojo as a simple Plexus component.

This moves the algorithm which is responsible for calculating the IU
dependency tree used by the dependency-tree Mojo to tycho-core, so that
it can be used by other projects.

For a given project, this tree can be calculated using the
P2DependencyTreeGenerator, which can be injected into a Mojo as a simple
Plexus component.
@ptziegler
Copy link
Contributor Author

Prerequisite to #3258

@laeubi
Copy link
Member

laeubi commented Jan 26, 2024

@ptziegler can this maybe even be moved to tycho-p2-maven-plugin? or does it require any class from tycho-core that is not in tycho-api?

@ptziegler
Copy link
Contributor Author

The "tycho-p2-maven-plugin"?

@laeubi
Copy link
Member

laeubi commented Jan 26, 2024

The "tycho-p2-maven-plugin"?

https://github.com/eclipse-tycho/tycho/tree/main/p2-maven-plugin

@ptziegler
Copy link
Contributor Author

Thanks. I was only looking at the projects starting with "tycho-" and completely missed that one 😅

But no, I need e.g. the TychoProjectManager to calculate the initial set of IUs that are required by a given Maven project.
While it's not strictly necessary (I could just precompute the list and then pass it as an additional argument), every method who wants to use this component would then have to effectively copy-paste the same code snippet.

image

@laeubi
Copy link
Member

laeubi commented Jan 26, 2024

Right I though I have moved tychoproject to api already but it seems not the case...

Copy link

Test Results

  579 files  ±0    579 suites  ±0   4h 0m 33s ⏱️ + 27m 29s
  392 tests ±0    384 ✅ +1   7 💤 ±0  1 ❌  - 1 
1 176 runs  ±0  1 153 ✅ +1  22 💤 ±0  1 ❌  - 1 

For more details on these failures, see this check.

Results for commit fea2bf8. ± Comparison against base commit cf9a060.

@laeubi laeubi added the backport-to-tycho-4.0.x Can be added to a PR to trigger an automatic backport of the change label Jan 27, 2024
@laeubi laeubi merged commit 502a622 into eclipse-tycho:main Jan 27, 2024
9 of 11 checks passed
Copy link

💚 All backports created successfully

Status Branch Result
tycho-4.0.x

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-tycho-4.0.x Can be added to a PR to trigger an automatic backport of the change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants