Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make "include" the default for referencedRepositoryMode #3252

Merged
merged 4 commits into from
Dec 14, 2023

Conversation

LorenzoBettini
Copy link
Contributor

Closes #3231

I added ignore in a few existing IT that now would fail 27d4db5

I added 2 new ITs to test the default behavior, and when ignore is passed 1e4f477. For these 2 new ITs, I relied on the Epsilon update site that I know has referenced repositories. I hope that's fine. I added the corresponding test methods into 1e4f477#diff-d6720b06bef8b3e5409e7044e315c4952389dfb8f160ff2ff965002fe333c98d. I don't know if that's the right place, but it looked like so.

Finally, I updated the release notes accordingly 6d72e7b. I took the chance to document that option in 4.0.2 where it was added (or backported?).

In some POMs of IT projects to avoid errors of the shape

[ERROR] Failed to load p2 repository from location
http://download.eclipse.org/dsdp/dd/updates: No repository found at
http://download.eclipse.org/dsdp/dd/updates

From what I understand: they use old Eclipse update sites, which might
contain references to repositories that do not exist anymore
Copy link

Test Results

   573 files  ±0     573 suites  ±0   4h 6m 44s ⏱️ + 37m 54s
   379 tests +2     372 ✔️ +1    6 💤 ±0  0 ±0  1 🔥 +1 
1 137 runs  +6  1 117 ✔️ +5  19 💤 ±0  0 ±0  1 🔥 +1 

For more details on these errors, see this check.

Results for commit 6d72e7b. ± Comparison against base commit 86be08f.

@LorenzoBettini
Copy link
Contributor Author

I don't think the failure in Windows is due to my change: I saw that IT test failed in other builds of mine in an unreliable way. Can it be flaky?

@LorenzoBettini
Copy link
Contributor Author

I can't seem to be authorized to restart that specific build.

@laeubi
Copy link
Member

laeubi commented Dec 14, 2023

@laeubi laeubi merged commit c2b4adb into eclipse-tycho:main Dec 14, 2023
8 of 10 checks passed
@LorenzoBettini LorenzoBettini deleted the tycho-3231 branch December 14, 2023 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make referencedRepositoryMode=include the default for target-platform-configuration
2 participants