Add support for Product Update-site names #2929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HannesWell
force-pushed
the
updateSiteNames
branch
4 times, most recently
from
e76119f to
67ec704
Compare
|
I just added a test-case and with that this is ready for me. The test-case also needs to be added to the master branch, but I suggest to do that as part of the update to the next p2 release, which also allows to revert all implementation changes done in Tycho in this PR. |
HannesWell
force-pushed
the
updateSiteNames
branch
from
67ec704 to
98fdd15
Compare
This a work-around to have eclipse-equinox/p2#353 available now and can be reverted once the mentioned change in P2 is available in Tycho.
HannesWell
force-pushed
the
updateSiteNames
branch
from
98fdd15 to
954c96e
Compare
HannesWell
added a commit
to HannesWell/tycho
that referenced
this pull request
Dec 5, 2023
This also reverts the temporary changes of PublishProductToolImpl made in eclipse-tycho#2929, which are obsolete now that the new P2 version has support for names of update-sites built in.
HannesWell
added a commit
to HannesWell/tycho
that referenced
this pull request
Dec 9, 2023
This also reverts the temporary changes of PublishProductToolImpl made in eclipse-tycho#2929, which are obsolete now that the new P2 version has support for names of update-sites built in.
HannesWell
added a commit
to HannesWell/tycho
that referenced
this pull request
Dec 9, 2023
This also reverts the temporary changes of PublishProductToolImpl made in eclipse-tycho#2929, which are obsolete now that the new P2 version has support for names of update-sites built in.
HannesWell
added a commit
that referenced
this pull request
Dec 9, 2023
This also reverts the temporary changes of PublishProductToolImpl made in #2929, which are obsolete now that the new P2 version has support for names of update-sites built in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This a work-around to have eclipse-equinox/p2#353 available now and can be reverted once the mentioned change in P2 is available in Tycho.
The reason for this is that I would like to use name-support in the product-definition already for the 2023-12 SimRel.
I'll take care about reverting this once the P2 updates for 2023-12 are available in Tycho.