Detect Eclipse version when setting up JUnit classpath?

[lppedd]

I was looking at this change:

And TBH it looks too forced. Like, this means I have to adjust the target platform as @Bananeweizen mentioned in another discussion.
Do you think there is a way to detect the environment and adjust accordingly?

I couldn't even find a separate p2 repository for JUnit 5, and as of now I wouldn't like to ditch the repository-based target platform.

[laeubi]

There are always ways but everything comes at a price, that is development effort and maintenance efforts. Beside that, there are releases and if one want to depend on the old stuff one can use old releases as well but this should not hinder those that want to move forward.

I couldn't even find a separate p2 repository for JUnit 5

You don't need a separate one, you can simply add one that contains this and pull in individual units. Or even just upgrade your products and benefit from many bugfixes and enhancements.

That said, if you like to propose a patch with an integration test that covers both cases and it does not adds too much complications to the code it could be considered.

[lppedd]

@laeubi nice! I had a look, but found there is another point to consider.

tycho/tycho-core/src/main/java/org/eclipse/tycho/core/resolver/DefaultTychoResolver.java

Lines 156 to 175 in 66e864f

	if (tychoProjectType instanceof BundleProject bundleProject) {
	List<ArtifactKey> testDependencies = bundleProject.getExtraTestRequirements(reactorProject);
	if (!testDependencies.isEmpty()) {
	logger.info(threadMarker + "Resolving test dependencies of " + project);
	DependencyResolverConfiguration testResolverConfiguration = new DependencyResolverConfiguration() {
	@Override
	public OptionalResolutionAction getOptionalResolutionAction() {
	return resolverConfiguration.getOptionalResolutionAction();
	}
	@Override
	public List<ArtifactKey> getExtraRequirements() {
	ArrayList<ArtifactKey> res = new ArrayList<>(resolverConfiguration.getExtraRequirements());
	res.addAll(testDependencies);
	return res;
	}
	};
	testDependencyArtifacts = resolver.resolveDependencies(session, project, preliminaryTargetPlatform,
	reactorProjects, testResolverConfiguration);
	}

This fails the entire build before arriving to OsgiBundleProject.

[laeubi]

I didn't said its trivial ;-)

But OSGiBundleProject actually is BundleProject ... and it calls the method mentioned above.

[lppedd]

@laeubi mmh, you're right, however it seems OsgiBundleProject#computeExtraTestClasspath is not invoked when building the target platform in DefaultTychoResolver.

In fact I think that computeExtraTestClasspath method actually requires an already built TP.
Basically getExtraTestRequirements is called earlier than computeExtraTestClasspath.

[lppedd]

I think I would probably need access to the preliminary target platform. But it seems its access is locked.

[lppedd]

@laeubi so to update you on this. I've opened up the preliminary target platform and got it working.
The reasoning is "do we have at least one JUnit 5 post-name-change dependency?".
If yes, use the new names, otherwise revert back to the old ones.
A pity I've found the blocking JupiterTestEngine issue.