From 0a825cd627b48565af5601bf54a014cc1501ad2c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=D0=90=D0=BB=D0=B5=D0=BA=D1=81=D0=B0=D0=BD=D0=B4=D1=8A?= =?UTF-8?q?=D1=80=20=D0=9A=D1=83=D1=80=D1=82=D0=B0=D0=BA=D0=BE=D0=B2?= Date: Fri, 12 Jan 2024 17:19:34 +0200 Subject: [PATCH] Log skipped TargetEnvironments only in debug This info is not helpful in majority of cases as setting a platform filter in the manifest is an explicit action which the developer does so there is no need to be reminded of that at the very beginning of the build where Maven usually gives warnings like missing plugin versions and etc. that makes it quite often considered as potential problem. Log in debug mode instead. (cherry picked from commit 8e50cab4dabd79389436d65236a2998e939062b8) --- ...DefaultTargetPlatformConfigurationReader.java | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/tycho-core/src/main/java/org/eclipse/tycho/core/resolver/DefaultTargetPlatformConfigurationReader.java b/tycho-core/src/main/java/org/eclipse/tycho/core/resolver/DefaultTargetPlatformConfigurationReader.java index 8dbc94c21b..176fac7edd 100644 --- a/tycho-core/src/main/java/org/eclipse/tycho/core/resolver/DefaultTargetPlatformConfigurationReader.java +++ b/tycho-core/src/main/java/org/eclipse/tycho/core/resolver/DefaultTargetPlatformConfigurationReader.java @@ -1,5 +1,5 @@ /******************************************************************************* - * Copyright (c) 2008, 2022 Sonatype Inc. and others. + * Copyright (c) 2008, 2024 Sonatype Inc. and others. * This program and the accompanying materials * are made available under the terms of the Eclipse Public License 2.0 * which accompanies this distribution, and is available at @@ -333,10 +333,10 @@ private void setBREEHeaderSelectionPolicy(TargetPlatformConfiguration result, Xp /** * Take the constraints of the configured execution environment into account when resolving - * dependencies or target definitions. These constraints include the list of system packages and - * the Bundle-RequiredExecutionEnvironment header. When set to true, the - * dependency resolution verifies that the bundle and all required bundles can be used in an - * OSGi container with the configured execution environment. + * dependencies or target definitions. These constraints include the list of system packages and the + * Bundle-RequiredExecutionEnvironment header. When set to true, the + * dependency resolution verifies that the bundle and all required bundles can be used in an OSGi + * container with the configured execution environment. */ private void setResolveWithEEContraints(TargetPlatformConfiguration result, Xpp3Dom resolverDom) { String value = getStringValue(resolverDom.getChild(RESOLVE_WITH_EXECUTION_ENVIRONMENT_CONSTRAINTS)); @@ -384,7 +384,7 @@ private void addTargetEnvironments(TargetPlatformConfiguration result, MavenProj } } if (!skipped.isEmpty()) { - logger.info(MessageFormat.format( + logger.debug(MessageFormat.format( "Declared TargetEnvironment(s) {0} are skipped for {1} as they do not match the project filter {2}.", skipped.stream().map(TargetEnvironment::toFilterProperties).map(String::valueOf) .collect(Collectors.joining(", ")), @@ -594,9 +594,9 @@ private static String getStringValue(Xpp3Dom element) { * * @param project * @param targetFile - * the target file to check + * the target file to check * @param otherTargetFiles - * other target files to take into account + * other target files to take into account * @return true if the target file is the primary artifact, false * otherwise */