Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4352] Add support to range column filters in table #4353

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[4352] Add support to range column filters in table #4353

wants to merge 1 commit into from

Conversation

frouene
Copy link
Contributor

@frouene frouene commented Dec 31, 2024

Bug: #4352

Pull request template

General purpose

What is the main goal of this pull request?

  • Bug fixes
  • New features
  • Documentation
  • Cleanup
  • Tests
  • Build / releng

Project management

  • Has the pull request been added to the relevant project and milestone? (Only if you know that your work is part of a specific iteration such as the current one)
  • Have the priority: and pr: labels been added to the pull request? (In case of doubt, start with the labels priority: low and pr: to review later)
  • Have the relevant issues been added to the pull request?
  • Have the relevant labels been added to the issues? (area:, difficulty:, type:)
  • Have the relevant issues been added to the same project and milestone as the pull request?
  • Has the CHANGELOG.adoc been updated to reference the relevant issues?
  • Have the relevant API breaks been described in the CHANGELOG.adoc? (Including changes in the GraphQL API)
  • In case of a change with a visual impact, are there any screenshots in the CHANGELOG.adoc? For example in doc/screenshots/2022.5.0-my-new-feature.png

Architectural decision records (ADR)

  • Does the title of the commit contributing the ADR start with [doc]?
  • Are the ADRs mentioned in the relevant section of the CHANGELOG.adoc?

Dependencies

  • Are the new / upgraded dependencies mentioned in the relevant section of the CHANGELOG.adoc?
  • Are the new dependencies justified in the CHANGELOG.adoc?

Frontend

This section is not relevant if your contribution does not come with changes to the frontend.

General purpose

  • Is the code properly tested? (Plain old JavaScript tests for business code and tests based on React Testing Library for the components)

Typing

We need to improve the typing of our code, as such, we require every contribution to come with proper TypeScript typing for both changes contributing new files and those modifying existing files.
Please ensure that the following statements are true for each file created or modified (this may require you to improve code outside of your contribution).

  • Variables have a proper type
  • Functions’ arguments have a proper type
  • Functions’ return type are specified
  • Hooks are properly typed:
    • useMutation<DATA_TYPE, VARIABLE_TYPE>(…)
    • useQuery<DATA_TYPE, VARIABLE_TYPE>(…)
    • useSubscription<DATA_TYPE, VARIABLE_TYPE>(…)
    • useMachine<CONTEXT_TYPE, EVENTS_TYPE>(…)
    • useState<STATE_TYPE>(…)
  • All components have a proper typing for their props
  • No useless optional chaining with ?. (if the GraphQL API specifies that a field cannot be null, do not treat it has potentially null for example)
  • Nullable values have a proper type (for example let diagram: Diagram | null = null;)

Backend

This section is not relevant if your contribution does not come with changes to the backend.

General purpose

  • Are all the event handlers tested?
  • Are the event processor tested?
  • Is the business code (services) tested?
  • Are diagram layout changes tested?

Architecture

  • Are data structure classes properly separated from behavioral classes?
  • Are all the relevant fields final?
  • Is any data structure mutable? If so, please write a comment indicating why
  • Are behavioral classes either stateless or side effect free?

Review

How to test this PR?

Please describe here the various use cases to test this pull request

  • Has the Kiwi TCMS test suite been updated with tests for this contribution?

@frouene frouene added this to the 2025.2.0 milestone Dec 31, 2024
@frouene frouene self-assigned this Dec 31, 2024
@frouene frouene requested a review from sbegaudeau as a code owner December 31, 2024 08:15
@frouene frouene linked an issue Dec 31, 2024 that may be closed by this pull request
Range column filters are not supported by tables #4352
Open
@frouene frouene removed their assignment Dec 31, 2024
@frouene frouene force-pushed the fro/enh/table-range-filter branch from 55cb3ac to c826012 Compare December 31, 2024 08:50
sbegaudeau
sbegaudeau requested changes Jan 3, 2025
View reviewed changes
packages/tables/backend/sirius-components-tables/pom.xml
Comment on lines +59 to +62
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-databind</artifactId>
</dependency>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not reviewed the whole PR but a change to a pom.xml is always something important so I've only looked at this file.

sirius-components-tables like most very low level parts of Sirius Components should not have any dependency to anything unless it is absolutely critical. The job done with this code should not be the responsibility of this project. It is not the responsibility of sirius-components-tables to support the fact that the table range column filters are serialized over the network in this way.

...ckend/sirius-components-core/src/main/java/org/eclipse/sirius/components/core/URLParser.java
var rawValue = value.substring(1);
rawValue = rawValue.substring(0, rawValue.indexOf("]"));
return Arrays.stream(rawValue.split(",")).toList();
var rawValue = value.substring(1, value.length() - 1);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you explain me what this change of behavior supposed to do? It's a bit complex to understand just from a Quick Look at the code, what is the difference in the old vs new behavior?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the filter values of a column can be a list, we end up with uri of this type [467ec1c3-8ba7-32dc-9d72-71a2ccad161b:["0","1"],4752c1c3-8ba7-32dc-9d72-71a2ccad161b:["1","2"]]
The previous implementation of getParameterEntries split each , whiche end up giving something like 467ec1c3-8ba7-32dc-9d72-71a2ccad161b:["0" ,"1"] ...
In the new approach, I consider the level of [ to only split the first list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbegaudeau sbegaudeau sbegaudeau requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
pr: to review soon priority: low
Projects
None yet
Milestone
2025.2.0
Development

Successfully merging this pull request may close these issues.

Range column filters are not supported by tables
2 participants
@frouene @sbegaudeau