[4343] Keep filters when opening a table #4344
Conversation
| @@ -150,7 +150,7 @@ private CursorBasedPaginationData getCursorBasedPaginationData(IEditingContext e | |||
| } | |||
|
|
|||
| private String getGlobalFilter(String representationId) { | |||
| String globalFilter = ""; | |||
| String globalFilter = null; | |||
There was a problem hiding this comment.
I don't understand why TableCreationParameters.Builder#globalFilter or TableCreationParameters.Builder#columnFilters has to be nullable nor why it has to be nullable in org.eclipse.sirius.components.tables.components.TableComponentPropseither and everywhere else for that matter and why you are trying to propagate even more null values everywhere.
You are doing this and deep down in TableComponent, you now have to do:
var globalFilter = this.props.globalFilter();
if (this.props.globalFilter() == null) {
globalFilter = optionalPreviousTable.map(Table::getGlobalFilter).orElse("");
variableManager.put(TableRenderer.GLOBAL_FILTER_DATA, globalFilter);
}
List<ColumnFilter> columnsFilters;
if (this.props.columnFilters() == null) {
columnsFilters = optionalPreviousTable.map(Table::getColumnFilters).orElse(List.of());
} else {
columnsFilters = this.props.columnFilters();
}
Why aren't those values initialized properly in TableEventProcessorFactory given that you already have access to the previous version of the table? I don't see why more null solves anything given that you have to fallback to a proper value in the frontend
const [globalFilter, setGlobalFilter] = useState<string>(table.globalFilter ?? '');
useEffect(() => {
if (enableGlobalFilter) {
changeGlobalFilterValue(globalFilter ?? '');
onGlobalFilterChange(globalFilter ?? '');
}
}, [globalFilter]);
useEffect(() => {
setGlobalFilter(table.globalFilter ?? '');
}, [table.globalFilter]);
What state of the table is null supposed to represent?
There was a problem hiding this comment.
When we open an existing table, we are unaware of the persisted value of the global filter on the front end (the same applies to the column filter). However, we do not want to send an empty value to the backend, as this would override the previous value (similar to when a user clicks the clear button in the filter section). Therefore, we need to recognize that we are in a situation where the table's global filter is not yet known, which is why I used the null value.
There was a problem hiding this comment.
When we open an existing table, we are unaware of the persisted value of the global filter on the front end (the same applies to the column filter). However, we do not want to send an empty value to the backend, as this would override the previous value (similar to when a user clicks the clear button in the filter section). Therefore, we need to recognize that we are in a situation where the table's global filter is not yet known, which is why I used the null value.
There was a problem hiding this comment.
I understand why the frontend can send a lack of value to the back in the URL of the subscription sure but here we are opening the representation and we have the table from the database so we both know that:
- The frontend can't really send a meaningful value
- The source of truth is what has been persisted in the backend the last time
So why give null to everybody if the real answer is just next to us? Am I mistaken in thinking that the only possible value here is the real value coming the previous table loaded line 88?
There was a problem hiding this comment.
Yes, you're right, I didn't understand your comment at first. I can indeed directly retrieve the persisted value without needing to handle the null case.
I've updated the PR to remove all nulls for globalSearch and columnFilter
frouene
force-pushed
the
fro/fix/table-filter-persist
branch
3 times, most recently
from
a20bd88 to
8e6c246
Compare
Bug: #4343 Signed-off-by: Florian ROUËNÉ <[email protected]>
sbegaudeau
force-pushed
the
fro/fix/table-filter-persist
branch
from
8e6c246 to
79d6ebd
Compare
Bug: #4343
Pull request template
General purpose
What is the main goal of this pull request?
Project management
priority:andpr:labels been added to the pull request? (In case of doubt, start with the labelspriority: lowandpr: to review later)area:,difficulty:,type:)CHANGELOG.adocbeen updated to reference the relevant issues?CHANGELOG.adoc? (Including changes in the GraphQL API)CHANGELOG.adoc? For example indoc/screenshots/2022.5.0-my-new-feature.pngArchitectural decision records (ADR)
[doc]?CHANGELOG.adoc?Dependencies
CHANGELOG.adoc?CHANGELOG.adoc?Frontend
This section is not relevant if your contribution does not come with changes to the frontend.
General purpose
Typing
We need to improve the typing of our code, as such, we require every contribution to come with proper TypeScript typing for both changes contributing new files and those modifying existing files.
Please ensure that the following statements are true for each file created or modified (this may require you to improve code outside of your contribution).
useMutation<DATA_TYPE, VARIABLE_TYPE>(…)useQuery<DATA_TYPE, VARIABLE_TYPE>(…)useSubscription<DATA_TYPE, VARIABLE_TYPE>(…)useMachine<CONTEXT_TYPE, EVENTS_TYPE>(…)useState<STATE_TYPE>(…)?.(if the GraphQL API specifies that a field cannot benull, do not treat it has potentiallynullfor example)let diagram: Diagram | null = null;)Backend
This section is not relevant if your contribution does not come with changes to the backend.
General purpose
Architecture
Review
How to test this PR?
Please describe here the various use cases to test this pull request