Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete icon shouldn't appear in non-deletable ListPropertySection #3932

Closed
wpiers opened this issue Aug 30, 2024 · 0 comments · Fixed by #3939
Closed

Delete icon shouldn't appear in non-deletable ListPropertySection #3932

wpiers opened this issue Aug 30, 2024 · 0 comments · Fixed by #3939
Assignees
@pcdavid
Labels
package: forms type: enhancement
Milestone
2024.9.0

Comments

@wpiers
Copy link
Contributor

wpiers commented Aug 30, 2024

When a ListPropertySection is configured as non-deletable, the delete icon appears as disabled.
It should be simply removed.
pcdavid added a commit that referenced this issue Aug 30, 2024
@pcdavid
[3932] Do not display the Delete button for non-deletable lists
99f5982 
Bug: #3932
Signed-off-by: Pierre-Charles David <[email protected]>
@pcdavid pcdavid mentioned this issue Aug 30, 2024
Merged
39 tasks
@pcdavid pcdavid linked a pull request Aug 30, 2024 that will close this issue
[3932] Do not display the Delete button for non-deletable lists #3939
Merged
39 tasks
@pcdavid pcdavid self-assigned this Aug 30, 2024
pcdavid added a commit that referenced this issue Sep 3, 2024
@pcdavid
[3932] Do not display the Delete button for non-deletable lists
3fabf47 
Bug: #3932
Signed-off-by: Pierre-Charles David <[email protected]>
@pcdavid pcdavid added this to the 2024.9.0 milestone Sep 3, 2024
pcdavid added a commit that referenced this issue Sep 3, 2024
@pcdavid
[3932] Do not display the Delete button for non-deletable lists
75f977e 
Bug: #3932
Signed-off-by: Pierre-Charles David <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pcdavid pcdavid

Labels
package: forms type: enhancement
Projects
None yet
Milestone
2024.9.0
Development

Successfully merging a pull request may close this issue.

[3932] Do not display the Delete button for non-deletable lists eclipse-sirius/sirius-web
2 participants
@pcdavid @wpiers