Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store form and property payload in a context #3758

Closed
mcharfadi opened this issue Jul 11, 2024 · 1 comment · Fixed by #3759 or #3844
Closed

Store form and property payload in a context #3758

mcharfadi opened this issue Jul 11, 2024 · 1 comment · Fixed by #3759 or #3844
Assignees
@mcharfadi
Labels
difficulty: medium package: forms type: enhancement
Milestone
2024.9.0

Comments

@mcharfadi
Copy link
Contributor

mcharfadi commented Jul 11, 2024 •
edited
Loading

No description provided.

@mcharfadi mcharfadi added this to the 2024.9.0 milestone Jul 11, 2024
@mcharfadi mcharfadi self-assigned this Jul 11, 2024
mcharfadi added a commit that referenced this issue Jul 11, 2024
@mcharfadi
[3758] Store property and form payload in a context
7f5f07c 
Bug: #3758
Signed-off-by: Michaël Charfadi <[email protected]>
@mcharfadi mcharfadi mentioned this issue Jul 11, 2024
Merged
39 tasks
@mcharfadi mcharfadi linked a pull request Jul 11, 2024 that will close this issue
[3758] Store property and form payload in a context #3759
Merged
39 tasks
mcharfadi added a commit that referenced this issue Jul 11, 2024
@mcharfadi
[3758] Store property and form payload in a context
59443c6 
Bug: #3758
Signed-off-by: Michaël Charfadi <[email protected]>
mcharfadi added a commit that referenced this issue Jul 23, 2024
@mcharfadi
[3758] Store property and form payload in a context
0916f51 
Bug: #3758
Signed-off-by: Michaël Charfadi <[email protected]>
mcharfadi added a commit that referenced this issue Jul 23, 2024
@mcharfadi
[3758] Store property and form payload in a context
99ec171 
Bug: #3758
Signed-off-by: Michaël Charfadi <[email protected]>
mcharfadi added a commit that referenced this issue Jul 24, 2024
@mcharfadi
[3758] Store property and form payload in a context
56538cc 
Bug: #3758
Signed-off-by: Michaël Charfadi <[email protected]>
mcharfadi added a commit that referenced this issue Jul 24, 2024
@mcharfadi
[3758] Store property and form payload in a context
ce59f8c 
Bug: #3758
Signed-off-by: Michaël Charfadi <[email protected]>
mcharfadi added a commit that referenced this issue Jul 25, 2024
@mcharfadi
[3758] Store property and form payload in a context
ca8343f 
Bug: #3758
Signed-off-by: Michaël Charfadi <[email protected]>
mcharfadi added a commit that referenced this issue Jul 26, 2024
@mcharfadi
[3758] Store property and form payload in a context
fd8b18c 
Bug: #3758
Signed-off-by: Michaël Charfadi <[email protected]>
mcharfadi added a commit that referenced this issue Jul 26, 2024
@mcharfadi
[3758] Store property and form payload in a context
524ee69 
Bug: #3758
Signed-off-by: Michaël Charfadi <[email protected]>
@sbegaudeau sbegaudeau reopened this Aug 5, 2024
@sbegaudeau
Copy link
Member

I'm reopening this issue since the fix does not match what I'm expecting:

  • There's no need to have two parallel way to store some stateful data in FormRepresentation.
  • All form based representations on the frontend should be impacted in a similar manner (Related elements, diagram filter, etc)
  • It does not make sense for the hook useDetailsViewSubscription to both return the form and the payload since the form is derived from the payload just like it does not make sense to store both the payload and the form in FormRepresentation.

mcharfadi added a commit that referenced this issue Aug 7, 2024
@mcharfadi
[3758] Store all form payload in a context
851a46f 
Bug: #3758
Signed-off-by: Michaël Charfadi <[email protected]>
@mcharfadi mcharfadi mentioned this issue Aug 7, 2024
Merged
39 tasks
@mcharfadi mcharfadi linked a pull request Aug 7, 2024 that will close this issue
[3758] Store all form payload in a context #3844
Merged
39 tasks
mcharfadi added a commit that referenced this issue Aug 7, 2024
@mcharfadi
[3758] Store all form payload in a context
6f4a1c0 
Bug: #3758
Signed-off-by: Michaël Charfadi <[email protected]>
mcharfadi added a commit that referenced this issue Aug 7, 2024
@mcharfadi
[3758] Store all form payload in a context
114eace 
Bug: #3758
Signed-off-by: Michaël Charfadi <[email protected]>
mcharfadi added a commit that referenced this issue Aug 7, 2024
@mcharfadi
[3758] Store all form payload in a context
dd80ed2 
Bug: #3758
Signed-off-by: Michaël Charfadi <[email protected]>
mcharfadi added a commit that referenced this issue Aug 7, 2024
@mcharfadi
[3758] Store all form payload in a context
971eedb 
Bug: #3758
Signed-off-by: Michaël Charfadi <[email protected]>
mcharfadi added a commit that referenced this issue Aug 8, 2024
@mcharfadi
[3758] Store all form payload in a context
a912ca0 
Bug: #3758
Signed-off-by: Michaël Charfadi <[email protected]>
mcharfadi added a commit that referenced this issue Aug 8, 2024
@mcharfadi
[3758] Store all form payload in a context
20af62b 
Bug: #3758
Signed-off-by: Michaël Charfadi <[email protected]>
mcharfadi added a commit that referenced this issue Aug 8, 2024
@mcharfadi
[3758] Store all form payload in a context
b8f0367 
Bug: #3758
Signed-off-by: Michaël Charfadi <[email protected]>
mcharfadi added a commit that referenced this issue Aug 26, 2024
@mcharfadi
[3758] Store all form payload in a context
f66dfd7 
Bug: #3758
Signed-off-by: Michaël Charfadi <[email protected]>
mcharfadi added a commit that referenced this issue Aug 28, 2024
@mcharfadi
[3758] Store all form payload in a context
03189f9 
Bug: #3758
Signed-off-by: Michaël Charfadi <[email protected]>
mcharfadi added a commit that referenced this issue Aug 28, 2024
@mcharfadi
[3758] Store all form payload in a context
bd8f932 
Bug: #3758
Signed-off-by: Michaël Charfadi <[email protected]>
mcharfadi added a commit that referenced this issue Aug 29, 2024
@mcharfadi
[3758] Store all form payload in a context
d325f5b 
Bug: #3758
Signed-off-by: Michaël Charfadi <[email protected]>
mcharfadi added a commit that referenced this issue Aug 29, 2024
@mcharfadi
[3758] Store all form payload in a context
e0ce686 
Bug: #3758
Signed-off-by: Michaël Charfadi <[email protected]>
mcharfadi added a commit that referenced this issue Aug 29, 2024
@mcharfadi
[3758] Store all form payload in a context
2a130e0 
Bug: #3758
Signed-off-by: Michaël Charfadi <[email protected]>
sbegaudeau pushed a commit that referenced this issue Aug 29, 2024
@mcharfadi @sbegaudeau
[3758] Store all form payload in a context
1edf925 
Bug: #3758
Signed-off-by: Michaël Charfadi <[email protected]>
sbegaudeau pushed a commit that referenced this issue Aug 29, 2024
@mcharfadi @sbegaudeau
[3758] Store all form payload in a context
7c5c6d3 
Bug: #3758
Signed-off-by: Michaël Charfadi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mcharfadi mcharfadi

Labels
difficulty: medium package: forms type: enhancement
Projects
None yet
Milestone
2024.9.0
2 participants
@sbegaudeau @mcharfadi