-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expanding/collapsing a node in the Explorer re-renders the whole workbench #3595
Comments
pcdavid
added a commit
that referenced
this issue
Jun 7, 2024
Bug: #3595 Signed-off-by: Pierre-Charles David <[email protected]>
39 tasks
39 tasks
sbegaudeau
pushed a commit
that referenced
this issue
Jun 10, 2024
Bug: #3595 Signed-off-by: Pierre-Charles David <[email protected]>
sbegaudeau
pushed a commit
that referenced
this issue
Jun 10, 2024
Bug: #3595 Signed-off-by: Pierre-Charles David <[email protected]>
sbegaudeau
pushed a commit
that referenced
this issue
Jun 10, 2024
Bug: #3595 Signed-off-by: Pierre-Charles David <[email protected]>
sbegaudeau
pushed a commit
that referenced
this issue
Jun 10, 2024
Bug: #3595 Signed-off-by: Pierre-Charles David <[email protected]>
This issue is reopened because the corresponding commit has been reverted by #3646 |
theogiraudet
pushed a commit
to mbats/Interactivity
that referenced
this issue
Jul 12, 2024
Bug: eclipse-sirius/sirius-web#3595 Signed-off-by: Pierre-Charles David <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This is particularly visible when a large diagram is opened.
There is no actual selection change, but since
SelectionContextProvider
'ssetSelection
does not check that it callssetState
with a new selection objet structurally equivalent but different in terms of identity. Now that the selection context is high in the component hierarchy, this re-renders the whole workbench, including the big diagram.The solution is the same as in d995d6e: update the selection state if the key is new value is really structurally different from the previous one.
The text was updated successfully, but these errors were encountered: