Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A tool cannot open a selection dialog in react flow #2759

Closed
1 task done
frouene opened this issue Dec 7, 2023 · 0 comments · Fixed by #3622 or #3658
Closed
1 task done

A tool cannot open a selection dialog in react flow #2759

frouene opened this issue Dec 7, 2023 · 0 comments · Fixed by #3622 or #3658
Assignees
@florianbarbin
Labels
difficulty: medium package: diagrams type: bug
Milestone
2024.9.0

Comments

@frouene
Copy link
Contributor

frouene commented Dec 7, 2023

  • I have specified the version :
  • latest (2023.12.0)

Steps to reproduce

  1. Open a flow model
  2. Create a representation Topography with auto layout
  3. On the CompositeProcessor1 palette's, trigger the tool Processor with Connection

Expected behavior (SPROTTY)

selection_dialog_sprotty

Actual behavior (REACT_FLOW)

selection_dialog_react_flow
@frouene frouene added this to the 2024.1.0 milestone Dec 7, 2023
@sbegaudeau sbegaudeau removed this from the 2024.1.0 milestone Dec 11, 2023
@florianbarbin florianbarbin self-assigned this Jun 18, 2024
@florianbarbin florianbarbin added this to the 2024.7.0 milestone Jun 18, 2024
@florianbarbin florianbarbin linked a pull request Jun 18, 2024 that will close this issue
[doc] Contribute an ADR to reactivate the selection dialog #3622
Merged
39 tasks
florianbarbin added a commit that referenced this issue Jun 18, 2024
@florianbarbin
[2759] Reactivate the SelectionDialog
6eb29cc 
In addtion, this commit introduce the generic concept of Dialog
to make it possible to define any kind of dialog for diagram node tools.

Bug:#2759
Signed-off-by: Florian Barbin <[email protected]>
florianbarbin added a commit that referenced this issue Jun 20, 2024
@florianbarbin
[2759] Reactivate the SelectionDialog
5f9763a 
In addtion, this commit introduce the generic concept of Dialog
to make it possible to define any kind of dialog for diagram node tools.

Bug:#2759
Signed-off-by: Florian Barbin <[email protected]>
florianbarbin added a commit that referenced this issue Jun 20, 2024
@florianbarbin
[2759] Reactivate the SelectionDialog
a9711f0 
In addtion, this commit introduce the generic concept of Dialog
to make it possible to define any kind of dialog for diagram node tools.

Bug:#2759
Signed-off-by: Florian Barbin <[email protected]>
florianbarbin added a commit that referenced this issue Jun 20, 2024
@florianbarbin
[2759] Reactivate the SelectionDialog
8c13160 
In addtion, this commit introduce the generic concept of Dialog
to make it possible to define any kind of dialog for diagram node tools.

Bug: #2759
Signed-off-by: Florian Barbin <[email protected]>
florianbarbin added a commit that referenced this issue Jun 20, 2024
@florianbarbin
[2759] Reactivate the SelectionDialog
99bd75e 
In addition, this commit introduces the generic concept of Dialog
to make it possible to define any kind of dialog for diagram node tools.

Bug: #2759
Signed-off-by: Florian Barbin <[email protected]>
@florianbarbin florianbarbin linked a pull request Jun 20, 2024 that will close this issue
[2759] Reactivate the SelectionDialog #3658
Merged
39 tasks
florianbarbin added a commit that referenced this issue Jun 20, 2024
@florianbarbin
[2759] Reactivate the SelectionDialog
6caeb67 
In addition, this commit introduces the generic concept of Dialog
to make it possible to define any kind of dialog for diagram node tools.

Bug: #2759
Signed-off-by: Florian Barbin <[email protected]>
florianbarbin added a commit that referenced this issue Jun 21, 2024
@florianbarbin
[2759] Reactivate the SelectionDialog
40c315e 
In addition, this commit introduces the generic concept of Dialog
to make it possible to define any kind of dialog for diagram node tools.

Bug: #2759
Signed-off-by: Florian Barbin <[email protected]>
florianbarbin added a commit that referenced this issue Jun 24, 2024
@florianbarbin
[2759] Reactivate the SelectionDialog
4c139c8 
In addition, this commit introduces the generic concept of Dialog
to make it possible to define any kind of dialog for diagram node tools.

Bug: #2759
Signed-off-by: Florian Barbin <[email protected]>
florianbarbin added a commit that referenced this issue Jun 25, 2024
@florianbarbin
[2759] Reactivate the SelectionDialog
578411d 
In addition, this commit introduces the generic concept of Dialog
to make it possible to define any kind of dialog for diagram node tools.

Bug: #2759
Signed-off-by: Florian Barbin <[email protected]>
florianbarbin added a commit that referenced this issue Jun 25, 2024
@florianbarbin
[2759] Provides the dialog type value in the NodeTool
0ddba48 
The front needs to know which kind of dialog it has to retrieve in the extension-point

Bug: #2759
Signed-off-by: Florian Barbin <[email protected]>
florianbarbin added a commit that referenced this issue Jun 25, 2024
@florianbarbin
[2759] Reactivate the SelectionDialog
45357b8 
In addition, this commit introduces the generic concept of Dialog
to make it possible to define any kind of dialog for diagram node tools.

Bug: #2759
Signed-off-by: Florian Barbin <[email protected]>
florianbarbin added a commit that referenced this issue Jun 25, 2024
@florianbarbin
[2759] Provides the dialog type value in the NodeTool
f048137 
The front needs to know which kind of dialog it has to retrieve in the extension-point

Bug: #2759
Signed-off-by: Florian Barbin <[email protected]>
florianbarbin added a commit that referenced this issue Jun 25, 2024
@florianbarbin
[2759] Provides the dialog type value in the NodeTool
c1fbbc1 
The front needs to know which kind of dialog it has to retrieve in the
extension-point

Bug: #2759
Signed-off-by: Florian Barbin <[email protected]>
florianbarbin added a commit that referenced this issue Jun 25, 2024
@florianbarbin
[2759] Provides the dialog type value in the NodeTool
b75142f 
The front needs to know which kind of dialog it has to retrieve in the
extension-point

Bug: #2759
Signed-off-by: Florian Barbin <[email protected]>
florianbarbin added a commit that referenced this issue Jun 26, 2024
@florianbarbin
[2759] Provides the dialog type value in the NodeTool
a20983f 
The front needs to know which kind of dialog it has to retrieve in the
extension-point

Bug: #2759
Signed-off-by: Florian Barbin <[email protected]>
florianbarbin added a commit that referenced this issue Jun 27, 2024
@florianbarbin
[2759] Completes CHANGELOG Breaking changes
cf524ec 
* Remove some formatter annotations
* Fix unsafe check in DialogContext.tsx

Bug: #2759
Signed-off-by: Florian Barbin <[email protected]>
florianbarbin added a commit that referenced this issue Jun 27, 2024
@florianbarbin
[2759] Completes CHANGELOG Breaking changes
f830573 
* Remove some formatter annotations
* Fix unsafe check in DialogContext.tsx

Bug: #2759
Signed-off-by: Florian Barbin <[email protected]>
florianbarbin added a commit that referenced this issue Jun 27, 2024
@florianbarbin
[2759] Completes CHANGELOG Breaking changes
29bc1b4 
* Remove some formatter annotations
* Fix unsafe check in DialogContext.tsx

Bug: #2759
Signed-off-by: Florian Barbin <[email protected]>
florianbarbin added a commit that referenced this issue Jun 28, 2024
@florianbarbin
[2759] Reactivate the SelectionDialog
9a2828b 
In addition, this commit introduces the generic concept of Dialog
to make it possible to define any kind of dialog for diagram node tools.

Bug: #2759
Signed-off-by: Florian Barbin <[email protected]>
florianbarbin added a commit that referenced this issue Jun 28, 2024
@florianbarbin
[2759] Provides the dialog type value in the NodeTool
e2d3b3a 
The front needs to know which kind of dialog it has to retrieve in the
extension-point

Bug: #2759
Signed-off-by: Florian Barbin <[email protected]>
florianbarbin added a commit that referenced this issue Jun 28, 2024
@florianbarbin
[2759] Completes CHANGELOG Breaking changes
93b4a08 
* Remove some formatter annotations
* Fix unsafe check in DialogContext.tsx

Bug: #2759
Signed-off-by: Florian Barbin <[email protected]>
florianbarbin added a commit that referenced this issue Jul 3, 2024
@florianbarbin
[2759] Reactivate the SelectionDialog
521915e 
In addition, this commit introduces the generic concept of Dialog
to make it possible to define any kind of dialog for diagram node tools.

Bug: #2759
Signed-off-by: Florian Barbin <[email protected]>
florianbarbin added a commit that referenced this issue Jul 3, 2024
@florianbarbin
[2759] Provides the dialog type value in the NodeTool
5d87461 
The front needs to know which kind of dialog it has to retrieve in the
extension-point

Bug: #2759
Signed-off-by: Florian Barbin <[email protected]>
florianbarbin added a commit that referenced this issue Jul 3, 2024
@florianbarbin
[2759] Completes CHANGELOG Breaking changes
eb6761d 
* Remove some formatter annotations
* Fix unsafe check in DialogContext.tsx

Bug: #2759
Signed-off-by: Florian Barbin <[email protected]>
florianbarbin added a commit that referenced this issue Jul 3, 2024
@florianbarbin
[2759] Update PR according to the last review comments
1edcd95 
Bug: #2759
Signed-off-by: Florian Barbin <[email protected]>
florianbarbin added a commit that referenced this issue Jul 3, 2024
@florianbarbin
[2759] Update PR according to the last review comments
208d19e 
Bug: #2759
Signed-off-by: Florian Barbin <[email protected]>
florianbarbin added a commit that referenced this issue Jul 3, 2024
@florianbarbin
[2759] Update PR according to the last review comments
e48f435 
Bug: #2759
Signed-off-by: Florian Barbin <[email protected]>
florianbarbin added a commit that referenced this issue Jul 4, 2024
@florianbarbin
[2759] Update PR according to the last review comments
3f6485e 
Bug: #2759
Signed-off-by: Florian Barbin <[email protected]>
florianbarbin added a commit that referenced this issue Jul 8, 2024
@florianbarbin
[2759] Reactivate the SelectionDialog
32934f4 
In addition, this commit introduces the generic concept of Dialog
to make it possible to define any kind of dialog for diagram node tools.

Bug: #2759
Signed-off-by: Florian Barbin <[email protected]>
florianbarbin added a commit that referenced this issue Jul 8, 2024
@florianbarbin
[2759] Provides the dialog type value in the NodeTool
2e44b75 
The front needs to know which kind of dialog it has to retrieve in the
extension-point

Bug: #2759
Signed-off-by: Florian Barbin <[email protected]>
florianbarbin added a commit that referenced this issue Jul 8, 2024
@florianbarbin
[2759] Completes CHANGELOG Breaking changes
18cf4ec 
* Remove some formatter annotations
* Fix unsafe check in DialogContext.tsx

Bug: #2759
Signed-off-by: Florian Barbin <[email protected]>
florianbarbin added a commit that referenced this issue Jul 8, 2024
@florianbarbin
[2759] Update PR according to the last review comments
f9ec7fb 
Bug: #2759
Signed-off-by: Florian Barbin <[email protected]>
florianbarbin added a commit that referenced this issue Jul 10, 2024
@florianbarbin
[2759] Reactivate the SelectionDialog
f199ae7 
In addition, this commit introduces the generic concept of Dialog
to make it possible to define any kind of dialog for diagram node tools.

Bug: #2759
Signed-off-by: Florian Barbin <[email protected]>
florianbarbin added a commit that referenced this issue Jul 10, 2024
@florianbarbin
[2759] Provides the dialog type value in the NodeTool
1a7ecdd 
The front needs to know which kind of dialog it has to retrieve in the
extension-point

Bug: #2759
Signed-off-by: Florian Barbin <[email protected]>
florianbarbin added a commit that referenced this issue Jul 10, 2024
@florianbarbin
[2759] Completes CHANGELOG Breaking changes
1b3f31c 
* Remove some formatter annotations
* Fix unsafe check in DialogContext.tsx

Bug: #2759
Signed-off-by: Florian Barbin <[email protected]>
florianbarbin added a commit that referenced this issue Jul 10, 2024
@florianbarbin
[2759] Update PR according to the last review comments
c022bec 
Bug: #2759
Signed-off-by: Florian Barbin <[email protected]>
@frouene frouene modified the milestones: 2024.7.0, 2024.9.0 Jul 10, 2024
florianbarbin added a commit that referenced this issue Jul 10, 2024
@florianbarbin
[2759] Reactivate the SelectionDialog
7135ddd 
In addition, this commit introduces the generic concept of Dialog
to make it possible to define any kind of dialog for diagram node tools.

Bug: #2759
Signed-off-by: Florian Barbin <[email protected]>

[2759] Provides the dialog type value in the NodeTool

The front needs to know which kind of dialog it has to retrieve in the
extension-point

Bug: #2759
Signed-off-by: Florian Barbin <[email protected]>

[2759] Completes CHANGELOG Breaking changes

* Remove some formatter annotations
* Fix unsafe check in DialogContext.tsx

Bug: #2759
Signed-off-by: Florian Barbin <[email protected]>

[2759] Update PR according to the last review comments

Bug: #2759
Signed-off-by: Florian Barbin <[email protected]>
florianbarbin added a commit that referenced this issue Jul 10, 2024
@florianbarbin
[2759] Reactivate the SelectionDialog
4cbab02 
In addition, this commit introduces the generic concept of Dialog
to make it possible to define any kind of dialog for diagram node tools.

Bug: #2759
Signed-off-by: Florian Barbin <[email protected]>
florianbarbin added a commit that referenced this issue Jul 10, 2024
@florianbarbin
[2759] Reactivate the SelectionDialog
7544623 
In addition, this commit introduces the generic concept of Dialog
to make it possible to define any kind of dialog for diagram node tools.

Bug: #2759
Signed-off-by: Florian Barbin <[email protected]>
florianbarbin added a commit that referenced this issue Jul 10, 2024
@florianbarbin
[2759] Reactivate the SelectionDialog
d24c5bd 
In addition, this commit introduces the generic concept of Dialog
to make it possible to define any kind of dialog for diagram node tools.

Bug: #2759
Signed-off-by: Florian Barbin <[email protected]>
florianbarbin added a commit that referenced this issue Jul 11, 2024
@florianbarbin
[2759] Reactivate the SelectionDialog
46095ef 
In addition, this commit introduces the generic concept of Dialog
to make it possible to define any kind of dialog for diagram node tools.

Bug: #2759
Signed-off-by: Florian Barbin <[email protected]>
florianbarbin added a commit that referenced this issue Jul 12, 2024
@florianbarbin
[2759] Reactivate the SelectionDialog
e444ba2 
In addition, this commit introduces the generic concept of Dialog
to make it possible to define any kind of dialog for diagram node tools.

Bug: #2759
Signed-off-by: Florian Barbin <[email protected]>
sbegaudeau pushed a commit that referenced this issue Jul 19, 2024
@florianbarbin @sbegaudeau
[2759] Reactivate the SelectionDialog
df3f9cd 
In addition, this commit introduces the generic concept of Dialog
to make it possible to define any kind of dialog for diagram node tools.

Bug: #2759
Signed-off-by: Florian Barbin <[email protected]>
sbegaudeau pushed a commit that referenced this issue Jul 19, 2024
@florianbarbin @sbegaudeau
[2759] Reactivate the SelectionDialog
5e26d10 
In addition, this commit introduces the generic concept of Dialog
to make it possible to define any kind of dialog for diagram node tools.

Bug: #2759
Signed-off-by: Florian Barbin <[email protected]>
sbegaudeau pushed a commit that referenced this issue Jul 19, 2024
@florianbarbin @sbegaudeau
[2759] Reactivate the SelectionDialog
06bd199 
In addition, this commit introduces the generic concept of Dialog
to make it possible to define any kind of dialog for diagram node tools.

Bug: #2759
Signed-off-by: Florian Barbin <[email protected]>
sbegaudeau pushed a commit that referenced this issue Jul 19, 2024
@florianbarbin @sbegaudeau
[2759] Reactivate the SelectionDialog
89cdf78 
In addition, this commit introduces the generic concept of Dialog
to make it possible to define any kind of dialog for diagram node tools.

Bug: #2759
Signed-off-by: Florian Barbin <[email protected]>
sbegaudeau pushed a commit that referenced this issue Jul 19, 2024
@florianbarbin @sbegaudeau
[2759] Reactivate the SelectionDialog
1aca131 
In addition, this commit introduces the generic concept of Dialog
to make it possible to define any kind of dialog for diagram node tools.

Bug: #2759
Signed-off-by: Florian Barbin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@florianbarbin florianbarbin

Labels
difficulty: medium package: diagrams type: bug
Projects
None yet
Milestone
2024.9.0
3 participants
@sbegaudeau @florianbarbin @frouene