Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert into a plain Maven project/module #37

Open
pcdavid opened this issue Jun 4, 2024 · 2 comments · May be fixed by #49
Open

Convert into a plain Maven project/module #37

pcdavid opened this issue Jun 4, 2024 · 2 comments · May be fixed by #49

Comments

@pcdavid
Copy link
Member

pcdavid commented Jun 4, 2024

AFAICT, this project is only used in Sirius Web, which is a plain Maven project. The fact that it is designed to be built as an Eclipse plug-in first, and a Maven artefact second makes things more complex for no real benefit IMO.
There is actually very little code in the Eclipse-specific org.eclipse.sirius.emfjson.ide (mostly JsonDescriber.java).

@sbegaudeau
Copy link
Member

You could drop the question mark from the title :)
We should definitively move into this direction when we will have some time. It's very painful to test emfjson while working on API changes with Sirius Web at the moment. It has been an issue for multiple contributors in the past few months.

@sbegaudeau sbegaudeau changed the title Convert into a plain Maven project/module? Convert into a plain Maven project/module Jun 5, 2024
@pcdavid
Copy link
Member Author

pcdavid commented Jun 5, 2024

A more radical approach would be to move this directly inside Sirius Web. As long as the corresponding module does not have move dependencies as it has now, it could still be consumable as a Maven dependency, just using different coordinates, e.g.

<dependency>
  <groupId>org.eclipse.sirius</groupId>
  <artifactId>sirius-components-emf-json</artifactId>
  <version>2024.7.0-SNAPSHOT</version>
</dependency>

instead of

<dependency>
  <groupId>org.eclipse.sirius.emfjson</groupId>
  <artifactId>org.eclipse.sirius.emfjson</artifactId>
  <version>2.3.8-SNAPSHOT</version>
</dependency>

pcdavid added a commit that referenced this issue Jun 29, 2024
- Remove/disable all Eclipse-specific code, configuration and settings.
- Move the test code into the module's src/test folder.

Bug: #37
Signed-off-by: Pierre-Charles David <[email protected]>
@pcdavid pcdavid linked a pull request Jun 29, 2024 that will close this issue
pcdavid added a commit that referenced this issue Aug 21, 2024
Bug: #37
Signed-off-by: Pierre-Charles David <[email protected]>
@pcdavid pcdavid linked a pull request Aug 22, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants