-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert into a plain Maven project/module #37
Comments
You could drop the question mark from the title :) |
A more radical approach would be to move this directly inside Sirius Web. As long as the corresponding module does not have move dependencies as it has now, it could still be consumable as a Maven dependency, just using different coordinates, e.g. <dependency>
<groupId>org.eclipse.sirius</groupId>
<artifactId>sirius-components-emf-json</artifactId>
<version>2024.7.0-SNAPSHOT</version>
</dependency> instead of <dependency>
<groupId>org.eclipse.sirius.emfjson</groupId>
<artifactId>org.eclipse.sirius.emfjson</artifactId>
<version>2.3.8-SNAPSHOT</version>
</dependency> |
- Remove/disable all Eclipse-specific code, configuration and settings. - Move the test code into the module's src/test folder. Bug: #37 Signed-off-by: Pierre-Charles David <[email protected]>
Bug: #37 Signed-off-by: Pierre-Charles David <[email protected]>
AFAICT, this project is only used in Sirius Web, which is a plain Maven project. The fact that it is designed to be built as an Eclipse plug-in first, and a Maven artefact second makes things more complex for no real benefit IMO.
There is actually very little code in the Eclipse-specific
org.eclipse.sirius.emfjson.ide
(mostlyJsonDescriber.java
).The text was updated successfully, but these errors were encountered: