Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh option not available for some resources that are not closed projects #2538

Open
2 tasks done
DaveCarpeneto opened this issue Nov 25, 2024 · 1 comment · May be fixed by #2542
Open
2 tasks done

Refresh option not available for some resources that are not closed projects #2538

DaveCarpeneto opened this issue Nov 25, 2024 · 1 comment · May be fixed by #2542
Labels
bug Something isn't working regression

Comments

@DaveCarpeneto
Copy link
Contributor

Issue was introduced in Eclipse IDE for Java Developers, Version: 2024-03 (4.31.0), Build id: 20240307-1437 ( https://www.eclipse.org/downloads/download.php?file=/technology/epp/downloads/release/2024-03/R/eclipse-java-2024-03-R-win32-x86_64.zip )

This situation is NOT seen in the previous quarterly release (Version: 2023-12 (4.30.0), Build id: 20231201-2043), and I don't see anything mentioned regarding this functionality @ https://eclipse.dev/eclipse/news/4.31/ .

The code change that caused this was #1438. I submitted an initial fix for this @ #2003 , however that fix did not cover all cases.

I'm using Eclipse on Windows.

Steps to reproduce

A plugin that I work on has a view that extends org.eclipse.ui.navigator.CommonNavigator . In previous versions this provided 'Refresh (F5)' in the contextual menu for any resource. However now the menu option only exists for projects, but not other resources.

Fairly easy to trigger / reproduce. Plug-in Spy tells me the following for the menu entry I'm talking about here:

oldEclipseOScript

Community

  • I understand reporting an issue to this OSS project does not mandate anyone to fix it. Other contributors may consider the issue, or not, at their own convenience. The most efficient way to get it fixed is that I fix it myself and contribute it back as a good quality patch to the project.
@DaveCarpeneto DaveCarpeneto added the bug Something isn't working label Nov 25, 2024
@DaveCarpeneto
Copy link
Contributor Author

DaveCarpeneto commented Nov 25, 2024

Proposed fix: #2539

The contextual "Refresh" option is now presented if anything is selected that is not a closed project (put another way: the "Refresh" option is only omitted if all selections are closed projects).

DaveCarpeneto added a commit to DaveCarpeneto/eclipse.platform.ui that referenced this issue Nov 25, 2024
DaveCarpeneto added a commit to DaveCarpeneto/eclipse.platform.ui that referenced this issue Nov 26, 2024
…rojects eclipse-platform#2538

Change made since the fix to eclipse-platform#1438 unintentionally removed the "refresh" contextual menu for resources that are not projects. 

With this change the "refresh" contextual menu is shown if ANY navigator selection is either (A) an open project, or (B) a non-project resource. Put another way: the 'refresh' item is NOT shown if ALL selections are closed projects.

Fixes eclipse-platform#2538
DaveCarpeneto added a commit to DaveCarpeneto/eclipse.platform.ui that referenced this issue Dec 3, 2024
Refresh option not available for some resources that are not closed projects eclipse-platform#2538

Change made since the fix to eclipse-platform#1438 unintentionally removed the "refresh" contextual menu for resources that are not projects. 

With this change the "refresh" contextual menu is shown if ANY navigator selection is either (A) an open project, or (B) a non-project resource. Put another way: the 'refresh' item is NOT shown if ALL selections are closed projects.

Fixes eclipse-platform#2538
DaveCarpeneto added a commit to DaveCarpeneto/eclipse.platform.ui that referenced this issue Dec 3, 2024
Refresh option not available for some resources that are not closed projects eclipse-platform#2538

Change made since the fix to eclipse-platform#1438 unintentionally removed the "refresh" contextual menu for resources that are not projects. 

With this change the "refresh" contextual menu is shown if ANY navigator selection is either (A) an open project, or (B) a non-project resource. Put another way: the 'refresh' item is NOT shown if ALL selections are closed projects.

Fixes eclipse-platform#2538
DaveCarpeneto added a commit to DaveCarpeneto/eclipse.platform.ui that referenced this issue Dec 4, 2024
…rojects

Refresh option not available for some resources that are not closed projects eclipse-platform#2538

Change made since the fix to eclipse-platform#1438 unintentionally removed the "refresh" contextual menu for resources that are not projects.

With this change the "refresh" contextual menu is shown if ANY navigator selection is either (A) an open project, or (B) a non-project resource. Put another way: the 'refresh' item is NOT shown if ALL selections are closed projects.

Fixes eclipse-platform#2538
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working regression
Projects
None yet
2 participants