Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

How can I make it possible to always be able to make a pull request to any branch and only fetch the build artifacts without any merge ? #888

Closed
the-snowwhite opened this issue Nov 11, 2023 · 3 comments
Closed

How can I make it possible to always be able to make a pull request to any branch and only fetch the build artifacts without any merge ? #888

the-snowwhite opened this issue Nov 11, 2023 · 3 comments

Comments

@the-snowwhite
Copy link
Contributor

How can I make it possible to always be able to make a pull request to any branch and only fetch the build artifacts without any need to merge (and then close the PR after a build success)?

Based upon coming up with a better answer for this question
Than the fallback solution here:

The new answer is here:

The current implementation of this new feature is is currently stuck in this issue by this blocked pull request:
here:
#886 (review)

Is it possible to update this book to cover an always successful build where only the build artifacts are required and no merge is performed ?

Or is some sort of alternative needed ?
@the-snowwhite the-snowwhite mentioned this issue Nov 11, 2023
Closed
@the-snowwhite the-snowwhite changed the title How can I make it possible to always be able to make a pull request to any branch and only fetch the build artifacts wirhout any merge ? How can I make it possible to always be able to make a pull request to any branch and only fetch the build artifacts without any merge ? Nov 11, 2023
@the-snowwhite the-snowwhite mentioned this issue Nov 11, 2023
Closed
@the-snowwhite
Copy link
Contributor Author

#886 (comment)

@the-snowwhite
Copy link
Contributor Author

All I need is for the builder to skip the mvn -check command that requires an update of the.
Bundle-Version: 3.124.100.qualifier

only the last 2 mvn commands are required to generate build artifacts without a merge:

In the swt.binaries folder

mvn --batch-mode -Pbuild-individual-bundles -DforceContextQualifier=zzz -Dcompare-version-with-baselines.skip=true -Dmaven.compiler.failOnWarning=true install

In the main swt folder:

mvn --batch-mode -V -U -DforkCount=1 -Dcompare-version-with-baselines.skip=false -Dmaven.compiler.failOnWarning=true --fail-at-end -DskipNativeTests=false -DfailIfNoTests=false clean install

the-snowwhite added a commit to the-snowwhite/eclipse.platform.swt that referenced this issue Nov 12, 2023
@the-snowwhite
This PR is not to be merged.It is a placeholder for solving eclipse-p…
40a1c72 
…latform#888

The purpose is only for testing what can make the builder deliver build
artifacts that then can be downloaded.
In this specific case for testing a bugfix by copying 3 produced
binaries into a working Standard Eclipse PHP 2023-09
Which it what the R_29 maintenance branch works on.
The cherry picked version of this commit is after approval then supposed
to be able to be merged onto R_29_Maintenance or any other Maintenance
branch exactly when the branch is no longer required to deliver binaries
to the stream.
the-snowwhite added a commit to the-snowwhite/eclipse.platform.swt that referenced this issue Nov 12, 2023
@the-snowwhite
This PR is not to be merged.It is a placeholder for solving eclipse-p…
14b9880 
…latform#888

The purpose is only for testing what can make the builder deliver build
artifacts that then can be downloaded.
In this specific case for testing a bugfix by copying 3 produced
binaries into a working Standard Eclipse PHP 2023-09
Which it what the R_29 maintenance branch works on.
The cherry picked version of this commit is after approval then supposed
to be able to be merged onto R_29_Maintenance or any other Maintenance
branch exactly when the branch is no longer required to deliver binaries
to the stream.
@mickaelistria
Copy link
Contributor

you should build SWT locally to get what you want. Looking in the Jenkinsfile will show you concrete commands to build SWT.
Once you're happy with your local build (you successfully tested it) and think it's worth adding it into the project directly, you can create a PR and then see the output in https://ci.eclipse.org/releng/job/eclipse.platform.swt/view/change-requests/job/PR-883/lastSuccessfulBuild/artifact/eclipse.platform.swt.binaries/bundles/org.eclipse.swt.gtk.linux.x86_64/target/ (which you can also test).
If the PR succeeds without error nor broken tests, then it can be considered for a review and a merge.

the-snowwhite added a commit to the-snowwhite/eclipse.platform.swt that referenced this issue Nov 12, 2023
@the-snowwhite
This PR is only to be merged If eclipse-platform#888 is to be impleme…
9f22fbb 
…nted.

The purpose is making a Maintenance branch builder change functionality
so that it can deliver build artifacts  that then can be downloaded.
To test bugfixes under a freeze period.

A specific example could be
Testing a bugfix by copying 3 produced
binaries into a working Standard Eclipse PHP 2023-09.
Without the need to have a working compiler available.

The cherry picked version of this commit is after approval then supposed
to be able to be merged onto a Maintenance branch exactly when the
branch is no longer required to deliver binaries
to the stream.
Or
It can be delivered by
dependabot[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mickaelistria @the-snowwhite