Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Y-Build] Use openjdk-24-ea+31 for tests under linux-java24 #2738

Merged

Conversation

HannesWell
Copy link
Member

The openjdk and temurin early-access builds for Java-24 differ.

As requested in eclipse-jdt/eclipse.jdt.core#3228 (comment).

@@ -3,7 +3,7 @@ def STREAMS = config.Streams

def TEST_CONFIGURATIONS = [
[os: 'linux' , ws:'gtk' , arch: 'x86_64' , javaVersion: 21, agentLabel: 'ubuntu-2404' , javaHome: "tool(type:'jdk', name:'temurin-jdk21-latest')" ],
[os: 'linux' , ws:'gtk' , arch: 'x86_64' , javaVersion: 24, agentLabel: 'ubuntu-2404' , javaHome: "installTemurinJDK('24', 'linux', 'x86_64', 'ea')" ],
[os: 'linux' , ws:'gtk' , arch: 'x86_64' , javaVersion: 24, agentLabel: 'ubuntu-2404' , javaHome: "install('jdk', 'https://download.java.net/java/early_access/jdk24/30/GPL/openjdk-24-ea+30_linux-x64_bin.tar.gz')" ],
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stephan-herrmann do you prefer the latest openjdk 24-ea+30 or 24-ea+29 (at https://download.java.net/java/early_access/jdk24/29/GPL/openjdk-24-ea+29_linux-x64_bin.tar.gz) since you mentioned the latter in the originating issue.
If the failure only vanishes with the latter it's maybe a regression in 24-ea+29?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From JDT p.o.v. there are two aspects of selecting the JDK:

  • the temurin builds generally lack some files (jmods/*.jmod) that are relevant for tests - those files are present in openjdk builds
  • the exact build version is of lesser relevance for Y-builds, more relevant for https://ci.eclipse.org/jdt/job/eclipse.jdt.core-run.javac-24/ where we need recent fixes in javac

That said, the link provided by @MohananRahul looks good to me.

In the future we might decide to abandon reliance on jmod files, at which point we could switch back to temurin (to give them some additional testing 😄 ).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have latest 24-ea 31 : build https://download.java.net/java/early_access/jdk24/31/GPL/openjdk-24-ea+31_linux-x64_bin.tar.gz.

Thanks for the heads-up, looks like this is brand new. When I created this PR 31 was not yet available 😅

That said, the link provided by @MohananRahul looks good to me.

In the future we might decide to abandon reliance on jmod files, at which point we could switch back to temurin (to give them some additional testing 😄 ).

Great. We can set up as you need it. Luckily this is now quite flexible. Of course less requirements on the tests also sounds good.

With that I think this is ready.

@HannesWell HannesWell force-pushed the yBuild-test-linux-openjdk24-ea branch from b5a12f3 to 82e4615 Compare January 10, 2025 18:05
@akurtakov akurtakov changed the title [Y-Build] Use openjdk-24-ea+30 for tests under linux-java24 [Y-Build] Use openjdk-24-ea+31 for tests under linux-java24 Jan 10, 2025
The openjdk and temurin early-access builds for Java-24 differ.
@HannesWell HannesWell force-pushed the yBuild-test-linux-openjdk24-ea branch from 82e4615 to d35db13 Compare January 10, 2025 18:07
@HannesWell HannesWell merged commit f2e407e into eclipse-platform:master Jan 10, 2025
3 of 4 checks passed
@HannesWell HannesWell deleted the yBuild-test-linux-openjdk24-ea branch January 10, 2025 18:19
@HannesWell
Copy link
Member Author

Regenerated the jobs with this change applied an restarted the Y-build test for Linux and java-24 with the Y-build from this afternoon so you should see the results of this in about three hours as usual.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants