-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Build] Update, clean-up and use job for Maven publication #2718
[Build] Update, clean-up and use job for Maven publication #2718
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks okay. I can't judge all the details.
/request-license-review |
Currently the publication of the Maven artifacts of Eclipse happens in five jobs manually/directly defined in the 'Releng' Jenkins instance: 1. CBIaggregator 2. RepositoryValidator 3. PublishPlatformToMaven, PublishJDTtoMaven and PublishPDEToMaven Corresponding job-definitions for these jobs already exist in this SCM (except for the repository-validation), but the jobs generated from them (in the 'Releng' folder instead of the root) are not used. This change replaces the existing (unused) multiple job-definitions by a single Jenkins pipeline that contains all steps and performs the final publication for all covered projects in a single matrix. The new pipeline is updated to incorporate all the changes made in the meantime to the manually maintained publication jobs. The I-build job is changed to use the new publication job. With respect to the existing, manually maintained publication job, the new job is adjusted in the following aspects: - Rename job to just 'PublishToMaven'. The CBI part by itself is irrelevant and a tool in the publication process - Remove documentation about the jobs involved and scripts called from the job description as it's an implementation detail that can be looked up in the pipeline if of interest. - Don't require the 'projects-storage.eclipse.org-bot-ssh' SSH agent for the aggregation step. - Only run publication on explicit invocation (from I-builds). Remove the timer-trigger: Without changes a (re-)publication is not necessary. - Make '-snapshot' the default value of the 'snapshotOrRelease' parameter instead of '-release'.
b467438
to
f7fd82a
Compare
I already did a lot of testing in a separate job and there everything was fine. I mainly wanted to make you aware of the intended changes in the logic, i.e. the removed timer-trigger. And while talking about the trigger: |
Sorry, I've never had access to the sonatype repositories for this so I can't comment on that. I'm glad to see things more organized and cleaner! |
No problem, cleaning up stale/undesired staging repos (if they even really exist) can be done later at any time.
Then lets proceed here and apply this. There is still potential for optimization, e.g. parallelizing checks to hopefully speed them up, but that's something that can be done in a follow-up. |
The new PublishToMaven job has been created in the RelEng JIPP and added to the Publish to Maven view.
These jobs are now disabled (i.e. not triggered anymore) and I added a note that they are obsolete.
These unused jobs are now already deleted. |
Restore the previous definition of the 'snapshotOrRelease' parameter. Follow-up on - eclipse-platform#2718
Restore the previous (correct) definition of the 'snapshotOrRelease' parameter. Follow-up on - eclipse-platform#2718
Restore the previous (correct) definition of the 'snapshotOrRelease' parameter. Follow-up on - #2718
I think @elsazac have it. |
Currently the publication of the Maven artifacts of Eclipse happens in five jobs manually/directly defined in the 'Releng' Jenkins instance:
Corresponding job-definitions for these jobs already in this SCM (except for the repository-validation), but the jobs generated from them are not used.
This change replaces the existing (unused) multiple job-definitions by a single Jenkins pipeline that contains all steps and performs the final publication for all covered projects in a single matrix. The new pipeline is updated to incorporate all the changes made in the meantime to the manually maintained publication jobs.
The I-build job is changed to use the new publication job.
With respect to the existing, manually maintained publication job, the new job is adjusted in the following aspects:
With this change following Jenkins jobs can be deleted:
Releng
folder):And one new jobs will be added: