Run some pde.build tests with Tycho (second attempt) #980
Conversation
Missing tests require provisioning the "delta pack" (ie launchers for all Platforms)
|
|
Test Results 273 files + 3 273 suites +3 1h 1m 36s ⏱️ + 16m 15s For more details on these failures and errors, see this check. Results for commit cd9c8f3. ± Comparison against base commit eb34cab. ♻️ This comment has been updated with latest results. |
Seems it was too late yesterday, I fixed that now and also added an assumption to the launcher find method, this seems for me the most suitable solution because then we can merge this attempt already and add more work (e.g. enable more test) on top of it. |
laeubi
force-pushed
the
enable_test_attempt_2
branch
from
74d2f70 to
cd9c8f3
Compare
|
This seems to reproduce the test failures we see here I therefore think this PR should be merged so we can see them in regular verification builds and can fix/act on them... in addition to that it adds 35 new test we will be aware if they would break. @HannesWell @vik-chand any concerns? |
There was a problem hiding this comment.
This seems to reproduce the test failures we see here
* [120 P2Tests fail on master since I20231201-1800 #967](https://github.com/eclipse-pde/eclipse.pde/issues/967)
Yes, I checked a few failures and they are identical.
I therefore think this PR should be merged so we can see them in regular verification builds and can fix/act on them... in addition to that it adds 35 new test we will be aware if they would break.
It's not ideal but sounds like a suitable solution for the current situation. It will also help to verify a fix sooner.
Thank you @laeubi for making this possible so that we can detect regressions early.
Hopefully this prevent future regressions and will reduce the burden for @iloveeclipse to hunt down their causes.
| <configuration> | ||
| <product>org.eclipse.sdk.ide</product> | ||
| <testRuntime>p2Installed</testRuntime> | ||
| <testClass>org.eclipse.pde.build.tests.PDEBuildTestSuite</testClass> |
There was a problem hiding this comment.
Am I right, that this testClass is used for the default test goal execution of the tycho-surefire-plugin for eclipse-test-plugins and the overwritten value in the separate p2-tests execution refelects the second execution defined in this projects test.xml?
| <goals><goal>test</goal></goals> | ||
| <configuration> | ||
| <testClass>org.eclipse.pde.build.tests.P2TestSuite</testClass> | ||
| <systemProperties/> |
There was a problem hiding this comment.
| <systemProperties/> |
Is this necessary? The effective pom view says this element is not configured in a parent pom.
There was a problem hiding this comment.
This is to clear the inherited properties from the default execution/plugin configuration, one might can configure the default execution but lets dont complicate it too much as it already is :-)
There was a problem hiding this comment.
but lets dont complicate it too much as it already is :-)
That's fine :)
But depending on where the to clear property is defined and how this might not be sufficient and something like https://stackoverflow.com/a/33252763/14542697 needs to be applied.
I have not further checked where this is coming from exactly, but I'm sure you are aware of all that.
Just wanted to make sure, it is not just forgotten.
|
Thanks for enabling tests! Was a long outstanding PDE issue. |
|
I just saw aggregator build failing https://ci.eclipse.org/platform/job/eclipse.platform.releng.aggregator/job/PR-1639/1/console : I'm not sure it's caused by this one here but looks suspiciously connected. |
This looks lile caused by this PR. Should we quickly revert it before next build? |
I'm 90% that this will break the build. |
|
So let revert it. |
I see no possibility to do this from the github UI? If I see it right, we only need revert for 6e5138a |
This reverts commit 6e5138a as it will introduce cyclic build error in the aggregator build. See eclipse-platform/eclipse.platform.releng.aggregator#1639 See eclipse-pde#980
This reverts commit 6e5138a as it will introduce cyclic build error in the aggregator build. See eclipse-platform/eclipse.platform.releng.aggregator#1639 See #980
|
@laeubi : it is unfortunate we've had to revert this PR, but it has shown a potential to enable PDE tests. |
|
I'll give it a try later on, basically I think one can use a profile that we only enable when verification builds run (like the |
Sounds good. Another point is that it looked like the activated tests only use what have been build with the I-builds (see #984) and if I understand the config right, this is no surprise since the test-runtime is p2 provisioned? |
This is a fresh attempt based on
with some progress made here
but that was a dead end I think instead one should try to add a
category.xmlwith another execution that mirrors into the "deltapack folder" so if the test executes intarget/workthe goal would be to have a foldertarget/deltapack/eclipsethat mirrors everything needed as the "deltapack".